Add import/named to lint rules (#1050)

*Add import/named rule to .eslintrc to enable detecting import issues
* Use deep imports for Lodash
* Fix other misc lint issues (unused imports/variables)

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Author: adhityamamallan

.eslintrc.js

@@ -33,6 +33,7 @@ module.exports = {
     // Import rules
     'import/no-unresolved': 'error',
     'import/no-duplicates': 'error',
+    'import/named': 'error',
     'import/order': [
       'error',
       {

src/components/cron-schedule-input/cron-schedule-input-popover/cron-schedule-input-popover.styles.ts

@@ -26,13 +26,10 @@ export const styled = {
     })
   ),
 
-  ExamplesList: createStyled(
-    'div',
-    ({ $theme }: { $theme: Theme }): StyleObject => ({
-      display: 'flex',
-      flexDirection: 'column',
-    })
-  ),
+  ExamplesList: createStyled('div', {
+    display: 'flex',
+    flexDirection: 'column',
+  }),
 
   ExampleItem: createStyled(
     'div',

src/components/multi-select-filter/multi-select-menu/multi-select-menu.tsx

@@ -2,7 +2,7 @@ import { Fragment, useCallback, useEffect, useMemo, useState } from 'react';
 
 import { Button } from 'baseui/button';
 import { Checkbox } from 'baseui/checkbox';
-import { isEqual } from 'lodash';
+import isEqual from 'lodash/isEqual';
 
 import { overrides, styled } from './multi-select-menu.styles';
 import { type Props } from './multi-select-menu.types';

src/route-handlers/start-workflow/start-workflow.ts

@@ -1,6 +1,6 @@
 import { status } from '@grpc/grpc-js';
 import crypto from 'crypto';
-import { isEmpty } from 'lodash';
+import isEmpty from 'lodash/isEmpty';
 import { NextResponse, type NextRequest } from 'next/server';
 
 import dayjs from '@/utils/datetime/dayjs';

src/utils/logger/console/register-console-logger.ts

@@ -1,4 +1,4 @@
-import { isString } from 'lodash';
+import isString from 'lodash/isString';
 
 import { type Logger } from '..';
 

src/views/domain-workflows-archival/config/domain-workflows-archival-filters.config.ts

@@ -1,6 +1,6 @@
 import { createElement } from 'react';
 
-import { omit } from 'lodash';
+import omit from 'lodash/omit';
 
 import DateFilterV2 from '@/components/date-filter-v2/date-filter-v2';
 import { type DateFilterValue } from '@/components/date-filter-v2/date-filter-v2.types';

src/views/domains-page/helpers/get-all-domains.ts

@@ -1,4 +1,7 @@
 import 'server-only';
+// cache is not present in stable React 18's type definitions
+// It is available only in their canary, or with Next.js
+// eslint-disable-next-line import/named
 import { cache } from 'react';
 
 import getConfigValue from '@/utils/config/get-config-value';

src/views/workflow-actions/workflow-action-start-form/workflow-action-start-form.tsx

@@ -4,7 +4,8 @@ import { DatePicker } from 'baseui/datepicker';
 import { FormControl } from 'baseui/form-control';
 import { Input } from 'baseui/input';
 import { RadioGroup, Radio } from 'baseui/radio';
-import { get, isObjectLike } from 'lodash';
+import get from 'lodash/get';
+import isObjectLike from 'lodash/isObjectLike';
 import { Controller, type GlobalError, useWatch } from 'react-hook-form';
 
 import CronScheduleInput from '@/components/cron-schedule-input/cron-schedule-input';

src/views/workflow-actions/workflow-action-start-optional-section/__tests__/workflow-action-start-optional-section.test.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 
-import { get } from 'lodash';
+import get from 'lodash/get';
 import { useForm } from 'react-hook-form';
 
 import { fireEvent, render, screen, userEvent } from '@/test-utils/rtl';

src/views/workflow-actions/workflow-action-start-retry-policy/__tests__/workflow-action-start-retry-policy.test.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 
-import { get } from 'lodash';
+import get from 'lodash/get';
 import { useForm } from 'react-hook-form';
 
 import { render, screen, userEvent } from '@/test-utils/rtl';