Fix utf8 encoding for payload (#1039)

* fix utf8 encoding for payload

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

* split language test cases

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

---------

Signed-off-by: Assem Hafez <assem.hafez@uber.com>

Author: Assem-Uber

src/utils/data-formatters/__tests__/format-base64-payload.test.ts

@@ -0,0 +1,33 @@
+import formatBase64Payload from '../format-base64-payload';
+
+describe('formatBase64Payload', () => {
+  it('should decode English text from base64 correctly', () => {
+    const result = formatBase64Payload('RW5nbGlzaA==');
+    expect(result).toBe('English');
+  });
+
+  it('should decode Russian text from base64 correctly', () => {
+    const result = formatBase64Payload('0KDRg9GB0YHQutC40Lk=');
+    expect(result).toBe('Русский');
+  });
+
+  it('should decode Chinese text from base64 correctly', () => {
+    const result = formatBase64Payload('5Lit5paH');
+    expect(result).toBe('中文');
+  });
+
+  it('should decode Arabic text from base64 correctly', () => {
+    const result = formatBase64Payload('2KfZhNi52LHYqNmK2Kk=');
+    expect(result).toBe('العربية');
+  });
+
+  it('should decode Cyrillic text from base64 correctly', () => {
+    const result = formatBase64Payload('0JXQkw==');
+    expect(result).toBe('ЕГ');
+  });
+
+  it('should decode emoji from base64 correctly', () => {
+    const result = formatBase64Payload('8J+agA==');
+    expect(result).toBe('🚀');
+  });
+});

src/utils/data-formatters/format-base64-payload.ts

@@ -0,0 +1,3 @@
+export default function formatBase64Payload(payload: string) {
+  return Buffer.from(payload, 'base64').toString('utf-8');
+}

src/utils/data-formatters/format-failure-details.ts

@@ -1,11 +1,13 @@
 import { type Failure } from '@/__generated__/proto-ts/uber/cadence/api/v1/Failure';
 
+import formatBase64Payload from './format-base64-payload';
+
 const formatFailureDetails = (failure: Pick<Failure, 'details'> | null) => {
   if (!failure?.details) {
     return null;
   }
 
-  const decodedFailureDetails = atob(failure.details);
+  const decodedFailureDetails = formatBase64Payload(failure.details);
 
   try {
     return JSON.parse(decodedFailureDetails);

src/utils/data-formatters/format-input-payload.ts

@@ -2,6 +2,8 @@ import logger from '@/utils/logger';
 
 import losslessJsonParse from '../lossless-json-parse';
 
+import formatBase64Payload from './format-base64-payload';
+
 const separators = ['\n', ' '];
 
 const formatInputPayload = (
@@ -12,7 +14,7 @@ const formatInputPayload = (
     return null;
   }
 
-  const parsedData = atob(data);
+  const parsedData = formatBase64Payload(data);
   return parseMultipleInputs(parsedData);
 };
 

src/utils/data-formatters/format-payload.ts

@@ -1,5 +1,7 @@
 import losslessJsonParse from '../lossless-json-parse';
 
+import formatBase64Payload from './format-base64-payload';
+
 const formatPayload = (
   payload: { data?: string | null } | null | undefined
 ) => {
@@ -9,7 +11,7 @@ const formatPayload = (
     return null;
   }
 
-  const parsedData = atob(data);
+  const parsedData = formatBase64Payload(data);
 
   // try parsing as JSON
   try {

src/utils/data-formatters/format-workflow-history-event/format-external-workflow-execution-signaled-event.ts

@@ -1,3 +1,5 @@
+import formatBase64Payload from '../format-base64-payload';
+
 import formatWorkflowCommonEventFields from './format-workflow-common-event-fields';
 import { type ExternalWorkflowExecutionSignaledEvent } from './format-workflow-history-event.type';
 
@@ -14,7 +16,7 @@ const formatExternalWorkflowExecutionSignaledEvent = ({
 
   return {
     ...primaryCommonFields,
-    control: control ? parseInt(atob(control)) : null,
+    control: control ? parseInt(formatBase64Payload(control)) : null,
     initiatedEventId: parseInt(initiatedEventId),
     ...eventAttributes,
     ...secondaryCommonFields,

src/utils/data-formatters/format-workflow-history-event/format-request-cancel-external-workflow-execution-failed-event.ts

@@ -1,3 +1,5 @@
+import formatBase64Payload from '../format-base64-payload';
+
 import formatWorkflowCommonEventFields from './format-workflow-common-event-fields';
 import { type RequestCancelExternalWorkflowExecutionFailedEvent } from './format-workflow-history-event.type';
 
@@ -17,7 +19,7 @@ const formatRequestCancelExternalWorkflowExecutionFailedEvent = ({
   return {
     ...primaryCommonFields,
     cause,
-    control: control ? parseInt(atob(control)) : null,
+    control: control ? parseInt(formatBase64Payload(control)) : null,
     initiatedEventId: parseInt(initiatedEventId),
     ...eventAttributes,
     decisionTaskCompletedEventId: parseInt(decisionTaskCompletedEventId),

src/utils/data-formatters/format-workflow-history-event/format-request-cancel-external-workflow-execution-initiated-event.ts

@@ -1,3 +1,5 @@
+import formatBase64Payload from '../format-base64-payload';
+
 import formatWorkflowCommonEventFields from './format-workflow-common-event-fields';
 import { type RequestCancelExternalWorkflowExecutionInitiatedEvent } from './format-workflow-history-event.type';
 
@@ -14,7 +16,7 @@ const formatRequestCancelExternalWorkflowExecutionInitiatedEvent = ({
 
   return {
     ...primaryCommonFields,
-    control: control ? parseInt(atob(control)) : null,
+    control: control ? parseInt(formatBase64Payload(control)) : null,
     ...eventAttributes,
     decisionTaskCompletedEventId: parseInt(decisionTaskCompletedEventId),
     ...secondaryCommonFields,

src/utils/data-formatters/format-workflow-history-event/format-signal-external-workflow-execution-failed-event.ts

@@ -1,3 +1,5 @@
+import formatBase64Payload from '../format-base64-payload';
+
 import formatWorkflowCommonEventFields from './format-workflow-common-event-fields';
 import { type SignalExternalWorkflowExecutionFailedEvent } from './format-workflow-history-event.type';
 
@@ -18,7 +20,7 @@ const formatSignalExternalWorkflowExecutionFailedEvent = ({
     ...primaryCommonFields,
     ...eventAttributes,
     cause,
-    control: control ? parseInt(atob(control)) : null,
+    control: control ? parseInt(formatBase64Payload(control)) : null,
     initiatedEventId: parseInt(initiatedEventId),
     decisionTaskCompletedEventId: parseInt(decisionTaskCompletedEventId),
     ...secondaryCommonFields,

src/utils/data-formatters/format-workflow-history-event/format-signal-external-workflow-execution-initiated-event.ts

@@ -1,3 +1,4 @@
+import formatBase64Payload from '../format-base64-payload';
 import formatInputPayload from '../format-input-payload';
 
 import formatWorkflowCommonEventFields from './format-workflow-common-event-fields';
@@ -21,7 +22,7 @@ const formatSignalExternalWorkflowExecutionInitiatedEvent = ({
     ...eventAttributes,
     input: formatInputPayload(input),
     signalName,
-    control: control ? parseInt(atob(control)) : null,
+    control: control ? parseInt(formatBase64Payload(control)) : null,
     decisionTaskCompletedEventId: parseInt(decisionTaskCompletedEventId),
     ...secondaryCommonFields,
   };