Skip to content

Commit 05e750f

Browse files
authored
fix: adjust pointer events on menu wrappers (#3938)
1 parent d3d223f commit 05e750f

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

src/components/Menu/Menu.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,8 @@ class Menu extends React.Component<Props, State> {
603603
...(I18nManager.getConstants().isRTL ? { right: left } : { left }),
604604
};
605605

606+
const pointerEvents = visible ? 'box-none' : 'none';
607+
606608
return (
607609
<View
608610
ref={(ref) => {
@@ -627,12 +629,18 @@ class Menu extends React.Component<Props, State> {
627629
collapsable={false}
628630
accessibilityViewIsModal={visible}
629631
style={[styles.wrapper, positionStyle, style]}
630-
pointerEvents={visible ? 'box-none' : 'none'}
632+
pointerEvents={pointerEvents}
631633
onAccessibilityEscape={onDismiss}
632634
testID={`${testID}-view`}
633635
>
634-
<Animated.View style={{ transform: positionTransforms }}>
636+
<Animated.View
637+
pointerEvents={pointerEvents}
638+
style={{
639+
transform: positionTransforms,
640+
}}
641+
>
635642
<Surface
643+
pointerEvents={pointerEvents}
636644
style={[
637645
styles.shadowMenuContainer,
638646
shadowMenuContainerStyle,

src/components/__tests__/__snapshots__/Menu.test.tsx.snap

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ Array [
206206
>
207207
<View
208208
collapsable={false}
209+
pointerEvents="box-none"
209210
style={
210211
Object {
211212
"transform": Array [
@@ -249,6 +250,7 @@ Array [
249250
>
250251
<View
251252
collapsable={false}
253+
pointerEvents="box-none"
252254
style={
253255
Object {
254256
"backgroundColor": "rgb(243, 237, 246)",
@@ -845,6 +847,7 @@ Array [
845847
>
846848
<View
847849
collapsable={false}
850+
pointerEvents="box-none"
848851
style={
849852
Object {
850853
"transform": Array [
@@ -886,6 +889,7 @@ Array [
886889
>
887890
<View
888891
collapsable={false}
892+
pointerEvents="box-none"
889893
style={
890894
Object {
891895
"backgroundColor": "rgb(243, 237, 246)",

0 commit comments

Comments
 (0)