Skip to content

Get rid of sed usage inside Capact release pipeline scripts  #622

@pkosiec

Description

@pkosiec

Description

Refactor hack/make-release.sh and hack/release-charts.sh script:

  • Get rid of error-prone sed usage

Alternatives:

See the discussion #617

Reason

The current solution is very shortsighted. In case of Dashboard tag, the current approach replaces any tag property, which is a generic word. It's a matter of time when we have such duplicated property in the values.yaml file. Same with other properties, like branch, which could occur multiple times, as we have multiple sources support in Populator. Should we build more complex sed one-liners in future? Definitely not, so that would need to be addressed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ciRelates to CIenhancementNew feature or requestneeds-triageRelates to issues that should be refined

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions