chore: update test suite (#9)

* test: add test cases for deep require

* -: add default test command

* -: lint if internal modules are imported

* -: test all variations of the linter

* chore: try to lint the type import

* chore: note the bug and adapt the test suite

Author: Lorenzo Kappeler

.eslintrc.node.js

@@ -0,0 +1,9 @@
+module.exports = {
+  extends: ["./react.js"],
+  overrides: [
+    {
+      files: ["packMain.js"],
+      parser: "esprima",
+    },
+  ],
+}

.eslintrc.react.js

@@ -0,0 +1,9 @@
+module.exports = {
+  extends: ["./react.js"],
+  overrides: [
+    {
+      files: ["packMain.js"],
+      parser: "esprima",
+    },
+  ],
+}

index.js

@@ -100,5 +100,6 @@ module.exports = {
     "sort-keys": "off",
     "no-console": "error",
     "json/*": "error",
+    "import/no-internal-modules": "error",
   },
 }

package-lock.json

@@ -7,6 +7,7 @@
     "build": "pika build",
     "lint": "eslint --ext ts,js,tsx,jsx,json .",
     "format": "npm run lint -- --fix",
+    "test": "npm run test:unit",
     "test:unit": "./test/test.sh"
   },
   "repository": {
@@ -36,6 +37,7 @@
     "tslint": "^6.1.2"
   },
   "devDependencies": {
+    "@carforyou/api-client": "^16.1.0",
     "@pika/pack": "^0.5.0",
     "@pika/plugin-copy-assets": "^0.9.2",
     "@pika/plugin-standard-pkg": "^0.9.2",

package.json

@@ -0,0 +1,2 @@
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import picka from "@pika/pack/dist-src/index"

test/bad/js/internal-modules.js

@@ -0,0 +1,6 @@
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import picka from "@pika/pack/dist-src/index"
+// There is probably a bug with type imports:
+// https://github.com/benmosher/eslint-plugin-import/issues/1880
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+import { Entitlements } from "@carforyou/api-client/dist-types/types/models"

test/bad/ts/internal-modules.ts

@@ -1,25 +1,5 @@
 #!/usr/bin/env bash
 
-bad_expected=14
-good_expected=0
-
-bad_output=$(npx eslint --ignore-path .eslintignore.test --format json "test/bad/**/*")
-echo $bad_output
-
-bad_failures=$(echo $bad_output | npx jq ". | map(.errorCount) | add")
-
-if [ "$bad_failures" != "$bad_expected" ]; then
-  echo "Expected $bad_expected but got $bad_failures linting errors for badly formatted files"
-  exit 1
-fi
-
-
-good_output=$(npx eslint --ignore-path .eslintignore.test --format json "test/good/**/*")
-echo $good_output
-
-good_failures=$(echo $good_output | npx jq ". | map(.errorCount) | add")
-
-if [ "$good_failures" != "$good_expected" ]; then
-  echo "Expected $good_expected but got $good_failures linting errors for well formatted files"
-  exit 1
-fi
+${PWD}/test/testRunner.sh -c .eslintrc.js -g 0 -b 16
+${PWD}/test/testRunner.sh -c .eslintrc.react.js -g 0 -b 18
+${PWD}/test/testRunner.sh -c .eslintrc.node.js -g 0 -b 18

test/test.sh

@@ -0,0 +1,34 @@
+#!/usr/bin/env bash
+
+while getopts c:g:b: option
+do
+case "${option}"
+in
+c) CONFIG=${OPTARG};;
+g) good_expected=${OPTARG};;
+b) bad_expected=${OPTARG};;
+esac
+done
+
+bad_output=$(npx eslint --config ${CONFIG} --ignore-path .eslintignore.test --format json "test/bad/**/*")
+echo "Bad Test Cases:" 
+echo -n $bad_output | npx jq .
+
+bad_failures=$(echo $bad_output | npx jq ". | map(.errorCount) | add")
+
+if [ "$bad_failures" != "$bad_expected" ]; then
+  echo "Expected $bad_expected but got $bad_failures linting errors for badly formatted files"
+  exit 1
+fi
+
+
+good_output=$(npx eslint --ignore-path .eslintignore.test --format json "test/good/**/*")
+echo "Good Test Cases:"
+echo -n $good_output | npx jq .
+
+good_failures=$(echo $good_output | npx jq ". | map(.errorCount) | add")
+
+if [ "$good_failures" != "$good_expected" ]; then
+  echo -n "Expected $good_expected with CONFIG: ${CONFIG} but got $good_failures linting errors for well formatted files"
+  exit 1
+fi