From 41ba0337e11933f4b97e5f49b5fc8b8566b08ac3 Mon Sep 17 00:00:00 2001 From: Chris Jantzen Date: Fri, 14 Feb 2025 16:17:52 -0800 Subject: [PATCH 1/2] Implemented metadata on Get-SecretInfo --- .../SecretManagement.1Password.Extension.psm1 | 8 +++++++- tests/Get-SecretInfo.Tests.ps1 | 5 +++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 index 630950a..eb305e6 100644 --- a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 +++ b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 @@ -176,6 +176,12 @@ function Get-SecretInfo { 'PASSWORD' { [SecretType]::SecureString } Default { [SecretType]::Unknown } } + + $metadata = @{ + version = $item.version + created_at = Get-Date $item.created_at + updated_at = Get-Date $item.updated_at + } Write-Verbose $item.title @@ -185,7 +191,7 @@ function Get-SecretInfo { # See: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.secretmanagement/get-secret?view=ps-modules#-inputobject $keyList.Add( ` $(($item.title).ToLower()), ` - [SecretInformation]::new($item.title, $type, $($VaultName)) ` + [SecretInformation]::new($item.title, $type, $($VaultName), $metadata) ` ); } } diff --git a/tests/Get-SecretInfo.Tests.ps1 b/tests/Get-SecretInfo.Tests.ps1 index b10ad49..354b2b3 100644 --- a/tests/Get-SecretInfo.Tests.ps1 +++ b/tests/Get-SecretInfo.Tests.ps1 @@ -42,6 +42,11 @@ Describe 'It gets items' { $info | Should -HaveCount 1 } + it 'includes metadata' { + $info = Get-SecretInfo -Vault "$($testDetails.Vault)" + $info.Metadata.Count | Should -BeGreaterOrEqual 3 + } + AfterAll { if ($createdLogin) {& op item delete "$($testDetails.LoginName)"} } From 4c6e0ed07c433ba9d1b06577823bf0e1c6692198 Mon Sep 17 00:00:00 2001 From: Chris Jantzen Date: Tue, 18 Feb 2025 17:13:53 -0800 Subject: [PATCH 2/2] Implemented more metadata (id, additional info, and urls). --- .../SecretManagement.1Password.Extension.psm1 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 index eb305e6..39a2513 100644 --- a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 +++ b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 @@ -178,9 +178,12 @@ function Get-SecretInfo { } $metadata = @{ + id = $item.id version = $item.version created_at = Get-Date $item.created_at updated_at = Get-Date $item.updated_at + additional_information = $item.additional_information + urls = $item.urls } Write-Verbose $item.title