From fec97cefbd6a4e2716cbfa093279b084e0a6f3cd Mon Sep 17 00:00:00 2001 From: Benjamin Moles Date: Tue, 1 Apr 2025 17:45:12 +0200 Subject: [PATCH 1/2] Quote parameters to prevent errors when they contain whitespaces --- .../SecretManagement.1Password.Extension.psm1 | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 index 630950a..3b78c24 100644 --- a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 +++ b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psm1 @@ -142,10 +142,10 @@ function Get-SecretInfo { $commandArgs = [System.Collections.ArrayList]::new(); $commandArgs.AddRange(@('item', 'list')); if ($VaultParameters.AccountName) { - $commandArgs.AddRange(@('--account', "$($VaultParameters.AccountName)")); + $commandArgs.AddRange(@('--account', """$($VaultParameters.AccountName)""")); } if ($VaultParameters.OPVault) { - $commandArgs.AddRange(@('--vault', "$($VaultParameters.OPVault)")); + $commandArgs.AddRange(@('--vault', """$($VaultParameters.OPVault)""")); } $commandArgs.AddRange(@('--categories', '"LOGIN,PASSWORD"', '--format', 'json')); $result = Invoke-OpCommand $commandArgs; @@ -226,10 +226,10 @@ function Get-Secret { $commandArgs = [System.Collections.ArrayList]::new(); $commandArgs.AddRange(@('item', 'get', """$($Name)""")); if ($VaultParameters.AccountName) { - $commandArgs.AddRange(@('--account', "$($VaultParameters.AccountName)")); + $commandArgs.AddRange(@('--account', """$($VaultParameters.AccountName)""")); } if ($VaultParameters.OPVault) { - $commandArgs.AddRange(@('--vault', "$($VaultParameters.OPVault)")); + $commandArgs.AddRange(@('--vault', """$($VaultParameters.OPVault)""")); } $commandArgs.AddRange(@('--format', 'json')); $result = Invoke-OpCommand $commandArgs; @@ -331,10 +331,10 @@ function Set-Secret { $commandArgs = [System.Collections.ArrayList]::new(); $commandArgs.AddRange(@('item', 'get', """$($Name)""")); if ($VaultParameters.AccountName) { - $commandArgs.AddRange(@('--account', "$($VaultParameters.AccountName)")); + $commandArgs.AddRange(@('--account', """$($VaultParameters.AccountName)""")); } if ($VaultParameters.OPVault) { - $commandArgs.AddRange(@('--vault', "$($VaultParameters.OPVault)")); + $commandArgs.AddRange(@('--vault', """$($VaultParameters.OPVault)""")); } $commandArgs.AddRange(@('--format', 'json')); $result = Invoke-OpCommand $commandArgs; @@ -354,10 +354,10 @@ function Set-Secret { $commandArgs = [System.Collections.ArrayList]::new(); $commandArgs.AddRange(@('item', $verb)); if ($VaultParameters.AccountName) { - $commandArgs.AddRange(@('--account', "$($VaultParameters.AccountName)")); + $commandArgs.AddRange(@('--account', """$($VaultParameters.AccountName)""")); } if ($VaultParameters.OPVault) { - $commandArgs.AddRange(@('--vault', "$($VaultParameters.OPVault)")); + $commandArgs.AddRange(@('--vault', """$($VaultParameters.OPVault)""")); } $commandArgs.AddRange(@('--format', 'json')); @@ -477,10 +477,10 @@ function Remove-Secret { $commandArgs = [System.Collections.ArrayList]::new(); $commandArgs.AddRange(@('item', 'delete', """$($Name)""")); if ($VaultParameters.AccountName) { - $commandArgs.AddRange(@('--account', "$($VaultParameters.AccountName)")); + $commandArgs.AddRange(@('--account', """$($VaultParameters.AccountName)""")); } if ($VaultParameters.OPVault) { - $commandArgs.AddRange(@('--vault', "$($VaultParameters.OPVault)")); + $commandArgs.AddRange(@('--vault', """$($VaultParameters.OPVault)""")); } $commandArgs.Add("--archive") | Out-Null Write-Verbose ($commandArgs -join ' ') From 689d6d68e16ecc5a9b1489e79b7bff920f540411 Mon Sep 17 00:00:00 2001 From: Benjamin Moles Date: Tue, 1 Apr 2025 17:47:32 +0200 Subject: [PATCH 2/2] Increase release number in the *.psd1 files --- .../SecretManagement.1Password.Extension.psd1 | 2 +- SecretManagement.1Password.psd1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psd1 b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psd1 index 671a93b..1beba7f 100644 --- a/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psd1 +++ b/SecretManagement.1Password.Extension/SecretManagement.1Password.Extension.psd1 @@ -1,5 +1,5 @@ @{ - ModuleVersion = '2.0.0.0' + ModuleVersion = '2.0.0.1' RootModule = 'SecretManagement.1Password.Extension.psm1' FunctionsToExport = @('Get-Secret','Get-SecretInfo','Test-SecretVault','Set-Secret','Remove-Secret') } \ No newline at end of file diff --git a/SecretManagement.1Password.psd1 b/SecretManagement.1Password.psd1 index 4957ae7..ea72789 100644 --- a/SecretManagement.1Password.psd1 +++ b/SecretManagement.1Password.psd1 @@ -12,7 +12,7 @@ # RootModule = '' # Version number of this module. - ModuleVersion = '1.0.0' + ModuleVersion = '1.0.1' # Supported PSEditions # CompatiblePSEditions = @()