Skip to content

Commit cf74782

Browse files
CEL Dev Teamcopybara-github
authored andcommitted
No public description
PiperOrigin-RevId: 942390014
1 parent a3fb693 commit cf74782

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

common/internal/byte_string.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -307,15 +307,15 @@ absl::optional<size_t> ByteString::Find(absl::string_view needle,
307307
[&needle, pos](absl::string_view lhs) -> absl::optional<size_t> {
308308
absl::string_view::size_type i = lhs.find(needle, pos);
309309
if (i == absl::string_view::npos) {
310-
return absl::nullopt;
310+
return std::nullopt;
311311
}
312312
return i;
313313
},
314314
[&needle, pos](const absl::Cord& lhs) -> absl::optional<size_t> {
315315
absl::Cord cord = lhs.Subcord(pos, lhs.size() - pos);
316316
absl::Cord::CharIterator it = cord.Find(needle);
317317
if (it == cord.char_end()) {
318-
return absl::nullopt;
318+
return std::nullopt;
319319
}
320320
return pos +
321321
static_cast<size_t>(absl::Cord::Distance(cord.char_begin(), it));
@@ -331,14 +331,14 @@ absl::optional<size_t> ByteString::Find(const absl::Cord& needle,
331331
if (auto flat_needle = needle.TryFlat(); flat_needle) {
332332
absl::string_view::size_type i = lhs.find(*flat_needle, pos);
333333
if (i == absl::string_view::npos) {
334-
return absl::nullopt;
334+
return std::nullopt;
335335
}
336336
return i;
337337
}
338338
// Needle is fragmented, we have to do a linear scan.
339339
const size_t needle_size = needle.size();
340340
if (pos + needle_size > lhs.size()) {
341-
return absl::nullopt;
341+
return std::nullopt;
342342
}
343343
if (ABSL_PREDICT_FALSE(needle_size == 0)) {
344344
return pos;
@@ -354,7 +354,7 @@ absl::optional<size_t> ByteString::Find(const absl::Cord& needle,
354354
size_t found_pos = lhs.find(first_chunk, current_pos);
355355
if (found_pos == absl::string_view::npos ||
356356
found_pos > lhs.size() - needle_size) {
357-
return absl::nullopt;
357+
return std::nullopt;
358358
}
359359
if (lhs.substr(found_pos + first_chunk.size(),
360360
rest_of_needle.size()) == rest_of_needle) {
@@ -367,7 +367,7 @@ absl::optional<size_t> ByteString::Find(const absl::Cord& needle,
367367
absl::Cord cord = lhs.Subcord(pos, lhs.size() - pos);
368368
absl::Cord::CharIterator it = cord.Find(needle);
369369
if (it == cord.char_end()) {
370-
return absl::nullopt;
370+
return std::nullopt;
371371
}
372372
return pos +
373373
static_cast<size_t>(absl::Cord::Distance(cord.char_begin(), it));

common/internal/byte_string_test.cc

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ TEST_P(ByteStringTest, TryFlatLarge) {
766766
ByteString byte_string =
767767
ByteString(GetAllocator(), GetMediumOrLargeFragmentedCord());
768768
EXPECT_EQ(GetKind(byte_string), ByteStringKind::kLarge);
769-
EXPECT_THAT(byte_string.TryFlat(), Eq(absl::nullopt));
769+
EXPECT_THAT(byte_string.TryFlat(), Eq(std::nullopt));
770770
EXPECT_EQ(GetKind(byte_string), ByteStringKind::kLarge);
771771
}
772772

@@ -806,10 +806,10 @@ TEST_P(ByteStringTest, Find) {
806806
EXPECT_THAT(
807807
byte_string.Find("small string optimization!"),
808808
Optional(GetMediumStringView().find("small string optimization!")));
809-
EXPECT_THAT(byte_string.Find("not found"), Eq(absl::nullopt));
809+
EXPECT_THAT(byte_string.Find("not found"), Eq(std::nullopt));
810810
EXPECT_THAT(byte_string.Find(""), Optional(0));
811811
EXPECT_THAT(byte_string.Find("", 3), Optional(3));
812-
EXPECT_THAT(byte_string.Find("A string", 1), Eq(absl::nullopt));
812+
EXPECT_THAT(byte_string.Find("A string", 1), Eq(std::nullopt));
813813

814814
// Find cord
815815
EXPECT_THAT(byte_string.Find(absl::Cord("A string")), Optional(0));
@@ -820,33 +820,33 @@ TEST_P(ByteStringTest, Find) {
820820
byte_string.Find(absl::MakeFragmentedCord(
821821
{"A string", " that is too large for the small string optimization!",
822822
" extra"})),
823-
Eq(absl::nullopt));
823+
Eq(std::nullopt));
824824
EXPECT_THAT(byte_string.Find(GetMediumOrLargeFragmentedCord()), Optional(0));
825-
EXPECT_THAT(byte_string.Find(absl::Cord("not found")), Eq(absl::nullopt));
825+
EXPECT_THAT(byte_string.Find(absl::Cord("not found")), Eq(std::nullopt));
826826
EXPECT_THAT(byte_string.Find(absl::Cord("")), Optional(0));
827827
EXPECT_THAT(byte_string.Find(absl::Cord(""), 3), Optional(3));
828828
}
829829

830830
TEST_P(ByteStringTest, FindEdgeCases) {
831831
ByteString empty_byte_string(GetAllocator(), "");
832-
EXPECT_THAT(empty_byte_string.Find("a"), Eq(absl::nullopt));
832+
EXPECT_THAT(empty_byte_string.Find("a"), Eq(std::nullopt));
833833
EXPECT_THAT(empty_byte_string.Find(""), Optional(0));
834834
ByteString cord_byte_string =
835835
ByteString(GetAllocator(), GetMediumOrLargeCord());
836-
EXPECT_THAT(cord_byte_string.Find("not found"), Eq(absl::nullopt));
836+
EXPECT_THAT(cord_byte_string.Find("not found"), Eq(std::nullopt));
837837
ByteString byte_string = ByteString(GetAllocator(), GetMediumStringView());
838838

839839
// Needle longer than haystack.
840840
EXPECT_THAT(byte_string.Find(std::string(byte_string.size() + 1, 'a')),
841-
Eq(absl::nullopt));
841+
Eq(std::nullopt));
842842

843843
// Needle at the end.
844844
absl::string_view suffix = "optimization!";
845845
EXPECT_THAT(byte_string.Find(suffix),
846846
Optional(byte_string.size() - suffix.size()));
847847

848848
// pos at the end.
849-
EXPECT_THAT(byte_string.Find("a", byte_string.size()), Eq(absl::nullopt));
849+
EXPECT_THAT(byte_string.Find("a", byte_string.size()), Eq(std::nullopt));
850850
EXPECT_THAT(byte_string.Find("", byte_string.size()),
851851
Optional(byte_string.size()));
852852

@@ -877,7 +877,7 @@ TEST_P(ByteStringTest, FindEdgeCases) {
877877
// enough space for the rest.
878878
ByteString short_haystack(GetAllocator(), "abcdefg");
879879
absl::Cord needle_too_long = absl::MakeFragmentedCord({"ef", "gh"});
880-
EXPECT_THAT(short_haystack.Find(needle_too_long), Eq(absl::nullopt));
880+
EXPECT_THAT(short_haystack.Find(needle_too_long), Eq(std::nullopt));
881881

882882
// Search with a fragmented empty cord.
883883
absl::Cord fragmented_empty_cord = absl::MakeFragmentedCord({"", ""});

0 commit comments

Comments
 (0)