From e1f2d7a720730e7b178abd722a436906befe5a07 Mon Sep 17 00:00:00 2001
From: kairav mittal <kairavmittal@gmail.com>
Date: Sat, 27 Jun 2026 18:48:22 +0530
Subject: [PATCH] Issue #428: suppress violations fix

---
 .../checkstyle/filters/LoadPatchFileUtils.java   | 10 ++++------
 .../filters/SuppressionPatchFilterTest.java      |  6 ++++++
 .../RenameWithModification/newline/Bar.java      |  9 +++++++++
 .../newline/defaultContext.patch                 | 16 ++++++++++++++++
 .../newline/defaultContextConfig.xml             | 13 +++++++++++++
 .../RenameWithModification/newline/expected.txt  |  0
 .../RenameWithModification/patchedline/Bar.java  |  9 +++++++++
 .../patchedline/defaultContext.patch             | 16 ++++++++++++++++
 .../patchedline/defaultContextConfig.xml         | 13 +++++++++++++
 .../patchedline/expected.txt                     |  1 +
 10 files changed, 87 insertions(+), 6 deletions(-)
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/Bar.java
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContext.patch
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContextConfig.xml
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/expected.txt
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/Bar.java
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContext.patch
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContextConfig.xml
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/expected.txt

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/filters/LoadPatchFileUtils.java b/src/main/java/com/puppycrawl/tools/checkstyle/filters/LoadPatchFileUtils.java
index 19d2b3ac..2683d7d8 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/filters/LoadPatchFileUtils.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/filters/LoadPatchFileUtils.java
@@ -69,12 +69,10 @@ public String getFileName() {
      */
     public List<List<Integer>> getLineRangeList() {
         final List<List<Integer>> lineRangeList = new ArrayList<>();
-        if (!"RENAME".equals(fileHeader.getChangeType().name())) {
-            for (HunkHeader hunkHeader : fileHeader.getHunks()) {
-                final EditList edits = hunkHeader.toEditList();
-                for (Edit edit : edits) {
-                    addSingleLineRange(lineRangeList, edit);
-                }
+        for (HunkHeader hunkHeader : fileHeader.getHunks()) {
+            final EditList edits = hunkHeader.toEditList();
+            for (Edit edit : edits) {
+                addSingleLineRange(lineRangeList, edit);
             }
         }
         return lineRangeList;
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
index 69983491..694b6dc9 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
@@ -51,6 +51,12 @@ public void testDefaultStrategy() throws Exception {
         testByConfig("DefaultStrategy/defaultContextConfig.xml");
     }
 
+    @Test
+    public void testRenameWithModification() throws Exception {
+        testByConfig("RenameWithModification/newline/defaultContextConfig.xml");
+        testByConfig("RenameWithModification/patchedline/defaultContextConfig.xml");
+    }
+
     @Test
     public void testFileLength() throws Exception {
         testByConfig("FileLength/newline/defaultContextConfig.xml");
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/Bar.java b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/Bar.java
new file mode 100644
index 00000000..400ac791
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/Bar.java
@@ -0,0 +1,9 @@
+package Checker;
+
+public class Foo {
+    public static void main(String[] args) {
+        System.out.println("hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh");
+        System.out.println();
+        System.out.println();
+    }
+}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContext.patch b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContext.patch
new file mode 100644
index 00000000..747e5f65
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContext.patch
@@ -0,0 +1,16 @@
+diff --git a/Foo.java b/Bar.java
+similarity index 55%
+rename from Foo.java
+rename to Bar.java
+index d188913..400ac79 100644
+--- a/Foo.java
++++ b/Bar.java
+@@ -2,7 +2,7 @@ package Checker;
+
+ public class Foo {
+     public static void main(String[] args) {
+-        System.out.println("short");
++        System.out.println("hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh");
+         System.out.println();
+         System.out.println();
+     }
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContextConfig.xml b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContextConfig.xml
new file mode 100644
index 00000000..2833e1a4
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/defaultContextConfig.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+          "https://checkstyle.org/dtds/configuration_1_3.dtd">
+<module name="Checker">
+  <module name="LineLength">
+    <property name="max" value="80"/>
+  </module>
+  <module name="com.puppycrawl.tools.checkstyle.filters.SuppressionPatchFilter">
+    <property name="file" value="${tp}/defaultContext.patch" />
+    <property name="strategy" value="newline" />
+  </module>
+</module>
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/newline/expected.txt
new file mode 100644
index 00000000..e69de29b
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/Bar.java b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/Bar.java
new file mode 100644
index 00000000..400ac791
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/Bar.java
@@ -0,0 +1,9 @@
+package Checker;
+
+public class Foo {
+    public static void main(String[] args) {
+        System.out.println("hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh");
+        System.out.println();
+        System.out.println();
+    }
+}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContext.patch b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContext.patch
new file mode 100644
index 00000000..747e5f65
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContext.patch
@@ -0,0 +1,16 @@
+diff --git a/Foo.java b/Bar.java
+similarity index 55%
+rename from Foo.java
+rename to Bar.java
+index d188913..400ac79 100644
+--- a/Foo.java
++++ b/Bar.java
+@@ -2,7 +2,7 @@ package Checker;
+
+ public class Foo {
+     public static void main(String[] args) {
+-        System.out.println("short");
++        System.out.println("hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh");
+         System.out.println();
+         System.out.println();
+     }
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContextConfig.xml b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContextConfig.xml
new file mode 100644
index 00000000..c1c7d002
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/defaultContextConfig.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+          "https://checkstyle.org/dtds/configuration_1_3.dtd">
+<module name="Checker">
+  <module name="LineLength">
+    <property name="max" value="80"/>
+  </module>
+  <module name="com.puppycrawl.tools.checkstyle.filters.SuppressionPatchFilter">
+    <property name="file" value="${tp}/defaultContext.patch" />
+    <property name="strategy" value="patchedline" />
+  </module>
+</module>
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/expected.txt
new file mode 100644
index 00000000..afc1931e
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/RenameWithModification/patchedline/expected.txt
@@ -0,0 +1 @@
+Bar.java:5: Line is longer than 80 characters (found 117).