[BUG] Any throw inside a settings click handler becomes an unhandled rejection

[chhoumann]

Found while fixing #1567.

#1567 was one instance of a general shape. Across src/, roughly a dozen onClick(async () => …) / onclick={async …} handlers hand Obsidian (or Svelte) a promise that is then discarded. Anything that throws inside one of them - not just a prompt cancellation - lands in the console as Uncaught (in promise) … with no notice, no log entry, and no indication to the user that the action failed.

Examples of the shape (not an exhaustive list):

• src/gui/AIAssistantProvidersModal.ts - the add-provider / add-model handlers
• src/gui/MacroGUIs/CommandSequenceEditor.ts - deleteCommand also does throw new Error("command not found")
• src/gui/choiceList/ChoiceView.svelte - deleteChoice and friends, passed as props into click handlers

#1567 fixed the cause for one modal by making it stop rejecting. That is the right fix there, but it does not generalise: the next genuine failure in any of these handlers still disappears into the console.

Shape of a fix: one seam, not a dozen try/catch blocks. Either a small runAction(fn) helper that handlers are routed through (reporting non-cancellation errors via reportError and swallowing cancellations), or a global unhandledrejection reporter registered on plugin load. Worth deciding which, because the per-handler version is exactly the boilerplate that failed to converge in #1567.

[chhoumann]

PR #1592 (for #1585) builds the seam this issue asks for, and routes the first host through it — so this is now a "finish the sweep" issue rather than a "decide the approach" one.

The seam, reportingHandler in src/utils/errorUtils.ts:

reportingHandler(contextMessage, fn) // -> (...args) => void

It covers both halves of the shape — a synchronous throw and a rejected promise — reports through the existing reportError, and stays silent for isCancellationError. It is the runAction(fn) option from the issue, not the global unhandledrejection one; that was rejected because it would catch other plugins' rejections too and could only produce context-free Notices.

Routed through it so far: ChoiceView.svelte's whole ChoiceListActions bag (wrapping the bag, not the buttons — every row button, context-menu item and nested list reaches the handlers through that one object, so the coverage is structural), plus openAISettings.

Still on the raw shape, i.e. what is left of this issue:

• src/gui/MacroGUIs/CommandSequenceEditor.ts — deleteCommand still throws explicitly; the quick-command and "Add …" handlers are unwrapped. (fix: the settings surface fails partially and visibly, never totally and silently #1592 stops the unrenderable-list case from reaching them, but a normal failure in them is still silent.)
• src/gui/AIAssistantProvidersModal.ts — the add-provider / add-model handlers
• src/gui/GlobalVariables/GlobalVariablesView.svelte
• the remaining onClick(async () => …) sites in src/gui/**

A grep-driven sweep of onClick(async / onclick={async is probably the honest way to close it, plus a note in AGENTS.md that a click handler goes through the seam.

[chhoumann]

Fixed by #1606 (merged) - the auto-close missed these because a single "Fixes" keyword only links its first issue number.