-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-native-gesture-handler from 2.20.2 to 2.29.1 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-native-gesture-handler from 2.20.2 to 2.29.1. See this package in npm: react-native-gesture-handler See this project in Snyk: https://app.snyk.io/org/chirag127/project/17310c6d-296d-4441-aa51-943dec153281?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @chirag127, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades react-native-gesture-handler from version 2.20.2 to 2.29.1. This is a significant update, spanning 17 versions, and includes numerous bug fixes and improvements as detailed in the release notes.
The changes in package.json and package-lock.json are mostly correct. However, I've identified an inconsistency in the version specifier for the upgraded package between package.json and package-lock.json. While package.json uses a tilde (~), which is consistent with other dependencies in the project, package-lock.json has been updated to use a caret (^). This could lead to unintentional minor version upgrades in the future. I've left a specific comment with a suggestion to resolve this.
After addressing this, the PR should be good to merge. It's always good practice to perform thorough testing after such a large dependency jump to ensure no breaking changes affect the application.
| "react-dom": "18.3.1", | ||
| "react-native": "0.82.1", | ||
| "react-native-gesture-handler": "~2.20.2", | ||
| "react-native-gesture-handler": "^2.29.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency in the version specifier for react-native-gesture-handler. In package.json, the version is updated to ~2.29.1, but here in package-lock.json (for the root package dependencies), it's ^2.29.1.
The tilde ~ allows patch updates, while the caret ^ allows minor updates. This change in the lock file alters the versioning strategy for this package, which might not be intended and could lead to unexpected versions being installed in the future.
Please ensure the package-lock.json is consistent with package.json. The specifier here should probably be ~2.29.1 to match package.json and the project's apparent convention for many expo and react-native related packages.
| "react-native-gesture-handler": "^2.29.1", | |
| "react-native-gesture-handler": "~2.29.1", |
Snyk has created this PR to upgrade react-native-gesture-handler from 2.20.2 to 2.29.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 17 versions ahead of your current version.
The recommended version was released a month ago.
Release notes
Package name: react-native-gesture-handler
🐛 Bug fixes
❗ Important changes
iOS26 by @ m-bert in #3740👍 Improvements
react-native-builder-bobby @ m-bert in #3751build.gradlecleanup by @ m-bert in #3741🐛 Bug fixes
setPressedby @ akwasniewski in #3742Pressable'sonPressbeing called on cancellation by @ latekvo in #3678🔢 Miscellaneous
Flingtsdoc by @ m-bert in #3724nodeon CI by @ m-bert in #3753evtoeventby @ tomekzaw in #3695paperCI by @ m-bert in #3677"build MacOS"CI taking a long time to complete by @ latekvo in #3679react-native0.82 by @ m-bert in #3699metro.config.jsin example apps by @ m-bert in #3718react-native-macosby @ m-bert in #3661New Contributors
Full Changelog: 2.28.0...2.29.0
❗ Important changes
react-native0.81 by @ m-bert in #3607gestureHandlerRootHOCby @ m-bert in #3632👍 Improvements
🐛 Bug fixes
🔢 Miscellaneous
New Contributors
Full Changelog: 2.27.2...2.28.0
❗ Important changes
asReversedinstead ofreversedby @ m-bert in #3598👍 Improvements
ReanimatedSwipeableby @ latekvo in #3579PressablerequiringdimensionsAfterResizeby @ latekvo in #3606focal/anchorpoints by @ m-bert in #3614🐛 Bug fixes
GestureDetectoronTextby @ m-bert in #3591onTouches*callbacks being called for all gestures by @ m-bert in #3596onPresscallback not working by @ latekvo in #3597🔢 Miscellaneous
ReanimatedSwipeablemodule path by @ m-bert in #3605dev clientdefault when startingexpo-exampleby @ m-bert in #3615New Contributors
Full Changelog: 2.27.1...2.27.2
What's Changed
/libmissing in the2.27.0npm releaseFull Changelog: 2.27.0...2.27.1
❗ Important changes
Pressablerefactor. by @ latekvo in #3571ForceTouchgesture by @ m-bert in #3550🐛 Bug fixes
README.mdto package by @ m-bert in #3558PointerTrackerelements nullable by @ m-bert in #3565🔢 Miscellaneous
needs-reproCI on comments by @ latekvo in #3570New Contributors
Full Changelog: 2.26.0...2.27.0
❗ Important changes
react-native0.80 by @ m-bert in #3530👍 Improvements
PressableandReanimatedSwipeableby @ m-bert in #3473🐛 Bug fixes
providers.execto enableconfiguration-cacheby @ lukmccall in #3504onPressifonLongPressis not defined by @ m-bert in #3549onSwipeableWillClosecalled on opening ofReanimatedSwipeableby @ m-bert in #3478🔢 Miscellaneous
react-native-builder-bobby @ satya164 in #3468GestureHandleron Android non generic by @ j-piasecki in