Skip to content
This repository was archived by the owner on Oct 15, 2018. It is now read-only.
This repository was archived by the owner on Oct 15, 2018. It is now read-only.

CacheableBitmapDrawable sets null in detach, should probably just set unused #55

@arberg

Description

@arberg

I suggest to replace current onDetachFromWindow with

@Override
protected void onAttachedToWindow() {
    super.onAttachedToWindow();
    onDrawableUnset(getDrawable());
}

@Override
protected void onDetachedFromWindow() {
    super.onDetachedFromWindow();
    onDrawableSet(getDrawable());
}

I had an issue earlier which caused me to disable using CacheableBitmapDrawable in favor of ImageView. I have now tested again with CacheableBitmapDrawable but could not reproduce problem (probably my usage has changed). However my memory told me the problem probably came from nulling. Hence the above change, which I deem healthy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions