-
Notifications
You must be signed in to change notification settings - Fork 89
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Add a way to control the tempo. This should be optional – possibly turned on with an attribute, maybe controls="tempo" (which might just reveal the control with CSS).
It's not clear what kind of control to use, an easy one would be <input type="number">.
The functionality itself is present in Magenta.js, we just need to call BasePlayer.setTempo(qpm) at the beginning of playback. However, this feature has some bugs apparently related to the fact that the Magenta.js player doesn't account for tempo when it sets durations:
- Note durations stay the same regardless of tempo, i.e. when the tempo is slow, all notes will sound too short, and vice versa (see Changing tempo should also change note length magenta/magenta-js#415)
- If the tempo is lower than the original tempo, playback will end too early, and vice versa
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request