[BUG] Mesh inset no longer centers

[1020alex]

Did you test the latest release build?

Yes, and the problem still exists.

Bug Description

In the mesh inset menu: when selecting maximize mesh and pressing center mesh, It no longer centers. Instead, I have to maximize -> Save settings -> Then center

Printer Model

Voxelab Aquila

Model Type

G32

Your Mainboard

Aquila GD32

Other Mainboard Type

No response

Add-ons that could be involved

No response

ProUI-EX | Extra Features?

Yes

Bed Leveling

BLT - BL Touch Bilinear mesh

Did you include your own configuration files?

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

[classicrocker883]

did this do what it was supposed to at one point? and you say it no longer does?

[classicrocker883]

looking through I see there may be a slight issue on the order of operation. Upon first flashing or resetting from default Center Mesh may give a wrong value. however, if you adjust the mesh Inset manually and then Center Mesh you should be able to let it work for you.

let me know if you get it to work and how you did it.

[1020alex]

Got it however.. Dont the instruction for physical setting calibration say I must first maximize, then center. Just trying to understand because I'm a bit lost. I could help you rework the way the user adjust physical settings etc, to be more streamline let me know.

[classicrocker883]

sorry for the delay response, and yes, I would absolutely like any input/help you have.

instructions could probably be made more clear some way.

so when you Maximize, then Center, it doesn't really work. Centering helps align the mesh equally. I suppose if your physical bed settings were not equal, like 230: X, 220: Y, then centering should give intended results.

I think the way the equation works now is it takes the min X as a starting point.

have you looked at the source code for this function (if you're able to compile and program C++)

[classicrocker883]

• in lcd/e3v2/proui/dwin.cpp you can replace void CenterMeshArea()
  see if that makes it better
  edited:

    void CenterMeshArea() {
      const float width  = MESH_MAX_X - MESH_MIN_X;
      const float height = MESH_MAX_Y - MESH_MIN_Y;
      const float center_x = X_BED_SIZE / 2;
      const float center_y = Y_BED_SIZE / 2;

      TERN_(PROUI_EX, PRO_data.mesh_min_x =) meshSet.mesh_min_x = center_x - width / 2;
      TERN_(PROUI_EX, PRO_data.mesh_max_x =) meshSet.mesh_max_x = center_x + width / 2;
      TERN_(PROUI_EX, PRO_data.mesh_min_y =) meshSet.mesh_min_y = center_y - height / 2;
      TERN_(PROUI_EX, PRO_data.mesh_max_y =) meshSet.mesh_max_y = center_y + height / 2;

      ResetMeshInset();
      ReDrawMenu();
    }

[1020alex]

So this is what I did but I still have a question. First I calibrated Steps p/mm (which will affect bed size etc), then probe offset which will put the probe correctly in center for (ABL/BLT), then auto home and put x and y to 0 both. Make sure nozzle touches the edge of the bed. If not adjust home offsets.? Once its to the edge of the bed move x and y until it reaches the other side of the bed. Is this bed size or x/y max values? Then comes the part I previously mentioned: centering and maximizing mesh. I though this could do it automatically?

[classicrocker883]

no centering is supposed to just take the values if they happen to be off center. maximize just resets the values to the bed size.

from one side of the bed to the other should be the bed size. max values are different. since you have a probe, its good to make those max values as much as you can, that way you can get as far right as possible (for probing).

basically the only reason to adjust the mesh inset is if you have bed clips. you dont want the probe to be in the way of that.

[1020alex]

1. "no centering is supposed to just take the values if they happen to be off center. maximize just resets the values to the bed size" : GOT IT, SO OF I MAXIMIZE- SAVE SETTINGS- RESTART PRINTER- CENTER MESH IT WILL WORK. THE ONLY PROBLEM IS THAT MRISOC OG FIRMWARE WORKED WHEN MAXIMIZE-CENTER MESH WERE DONE. NOT SURE WHY IT DOESNT WORK ON THIS FIRMWARE. ALSO DOES CENTERING JUST AFFECT BED SIZE NOT X/Y MAX VALUES?
2. "since you have a probe, its good to make those max values as much as you can, that way you can get as far right as possible (for probing)." GOT IT, BUT MY PROBE CANT REACH THE OTHER END OF THE BED DUE TO PHYSICAL LIMITATIONS. WHAT DO I DO THEN? THATS WHAT CENTER MESH IS FOR CORRECT?
3. LAST QUESTION WHEN I GO( X: 0.00 Y: 0.00 )THE NOZZLE SHOULD BE AT THE CORNER OF THE BED CORRECT? WHAT IF IT IS NOT?

Thanks

Sincerely, Alex.

[classicrocker883]

theres a lot to unpack here

1. You shouldn't have to restart the printer after saving. but if you do notice there is an actual difference versus let me know.
   
   1a. Maximize and Center mesh code is really the same with OG Mriscoc, hasn't changed in over 3 years. it should functionally be the same.
   its better now because originally it was limited due to the probe offset.
   so now when you start from default, and go right to Center or Maximize mesh, you may notice the X Max inset is off because of that offset (like 185) - its a small bug due to the original code, but once you edit it or Maximize again, that should give you the correct value (Min: 0, Max: 220).
   
   1b. im not sure how you mean by

   FIRMWARE WORKED WHEN MAXIMIZE-CENTER MESH WERE DONE. NOT SURE WHY IT DOESNT WORK ON THIS FIRMWARE

   I have improve on the centering. I have make a script which visually shows you the previous code vs the changes

Legend:

Dotted Line = Original Mesh Inset
Solid Green = New "Centered Mesh"
Red Dot = Center of Original Mesh
Blue Dot = Center of New Mesh

1st image: Original OG Code

2nd image: Updated/Improved

As you can see, the original limits the usefulness of centering. it makes the area much smaller, and resizes the shape to be square. Im not sure if its supposed to be made square? that I can make it do.

2. since the probe is limited by its reach, I suggest having a 5x5 or 7x7 grid. you may not physically be able to probe the right Column of points which is fine, because Auto Build Mesh will auto fill them in with good accuracy. in which after you can manually adjust them like in Manual Mesh.
   I think centering is just meant to make it easier putting in the Min/Max Mesh Inset values automatically. Probing the bed doesn't have an effect on the mesh inset, but mesh inset has an effect on where it probes the bed - if that makes sense. so Probing uses the mesh inset to know where to probe. like i said, if you have bed clips which might be in the way, then you adjust you mesh inset to account for them. which is why by default the values are set to 10-210 (or a mesh inset of 10). meaning it will probe 10mm away from the edge of the bed - so in other words it wont accidentally probe off the bed. otherwise youll be probing right on the edge.

3. when youre at 0,0 and the nozzle isnt exactly at the corner of the bed, thats okay. so the bed is actually 235x235. if you measure it or want to order a new one, that is the real size. so they say its 220 because its dangerous to print at the edge for obvious reasons, and plus they account for the bed clips. you can always maximize the physical settings if you want. it might be different for everyone. because I upgraded somethings, now my X and Y max is 240. so if I move to those spots, the nozzle will be off the bed. what you can do is set your Max Position to like 250, and bed size 230 in Phsyical Settings. then in the Prepare>Move Axis menu, move as far on the X and Y as it goes, but be sure to do a Live Move when its very close, then once it stops, see where that position is, and change your Max Position to that - so say it stops at 236, just make it 235. if the Nozzle is off the bed at 0,0 then you can adjust your Min Position or Home Offset.

[1020alex]

Got it. So rocker the problem is really that in order to maximize and center we have to go out of mesh inset menu (maximize), then save settings, reset printer, THEN go into mesh inset and center. Please allow the ability to maximize then center WITHOUT leaving the mesh inset settings.

[classicrocker883]

resetting the printer is not necessary, i mean as far as I know its not needed. saving too. only time you need to save is before shutting it down.

and maximize and center aren't really supposed to be used together. when you maximize that basically just resets everything. center is supposed to just help align the inset. i hope that clarifies. is theres anything else i can help with?