Fix some RPIT lifetime capturing issues that weren't automigrated

Author: coolreader18

crates/client-api/src/routes/energy.rs

@@ -22,7 +22,7 @@ pub async fn get_energy_balance<S: ControlStateDelegate>(
     Path(IdentityParams { identity }): Path<IdentityParams>,
 ) -> axum::response::Result<impl IntoResponse> {
     let identity = Identity::from(identity);
-    get_budget_inner(ctx, &identity).await
+    get_budget_inner(ctx, identity).await
 }
 
 #[serde_with::serde_as]
@@ -66,10 +66,10 @@ pub async fn add_energy<S: ControlStateDelegate>(
 
 async fn get_budget_inner(
     ctx: impl ControlStateDelegate,
-    identity: &Identity,
+    identity: Identity,
 ) -> axum::response::Result<impl IntoResponse> {
     let balance = ctx
-        .get_energy_balance(identity)
+        .get_energy_balance(&identity)
         .await
         .map_err(log_and_500)?
         .map_or(0, |quanta| quanta.get());

crates/commitlog/tests/streaming/mod.rs

@@ -214,7 +214,7 @@ fn repo(at: &Path) -> repo::Fs {
     repo::Fs::new(CommitLogDir::from_path_unchecked(at), None).unwrap()
 }
 
-fn create_reader(path: &Path, range: impl RangeBounds<u64>) -> impl AsyncBufRead {
+fn create_reader<R: RangeBounds<u64>>(path: &Path, range: R) -> impl AsyncBufRead + use<R> {
     BufReader::new(StreamReader::new(stream::commits(
         repo::Fs::new(CommitLogDir::from_path_unchecked(path), None).unwrap(),
         range,

crates/core/src/subscription/module_subscription_manager.rs

@@ -1095,14 +1095,14 @@ impl SubscriptionManager {
     fn queries_for_table_update<'a>(
         &'a self,
         table_update: &'a DatabaseTableUpdate,
-        find_rhs_val: &impl Fn(&JoinEdge, &ProductValue) -> Option<AlgebraicValue>,
+        find_rhs_val: impl Fn(&JoinEdge, &ProductValue) -> Option<AlgebraicValue>,
     ) -> impl Iterator<Item = &'a QueryHash> {
         let mut queries = HashSet::new();
         for hash in table_update
             .inserts
             .iter()
             .chain(table_update.deletes.iter())
-            .flat_map(|row| self.queries_for_row(table_update.table_id, row, find_rhs_val))
+            .flat_map(|row| self.queries_for_row(table_update.table_id, row, &find_rhs_val))
         {
             queries.insert(hash);
         }
@@ -1182,7 +1182,7 @@ impl SubscriptionManager {
             .iter()
             .filter(|table| !table.inserts.is_empty() || !table.deletes.is_empty())
             .flat_map(|table_update| {
-                self.queries_for_table_update(table_update, &|edge, row| find_rhs_val(edge, row, tx))
+                self.queries_for_table_update(table_update, |edge, row| find_rhs_val(edge, row, tx))
             })
             // deduplicate queries by their hash
             .filter({
@@ -2161,7 +2161,7 @@ mod tests {
         };
 
         let hashes = subscriptions
-            .queries_for_table_update(&table_update, &|_, _| None)
+            .queries_for_table_update(&table_update, |_, _| None)
             .collect::<Vec<_>>();
 
         assert!(hashes.len() == 3);
@@ -2179,7 +2179,7 @@ mod tests {
         };
 
         let hashes = subscriptions
-            .queries_for_table_update(&table_update, &|_, _| None)
+            .queries_for_table_update(&table_update, |_, _| None)
             .collect::<Vec<_>>();
 
         assert!(hashes.len() == 1);
@@ -2220,7 +2220,7 @@ mod tests {
         };
 
         let hashes = subscriptions
-            .queries_for_table_update(&table_update, &|_, _| None)
+            .queries_for_table_update(&table_update, |_, _| None)
             .cloned()
             .collect::<Vec<_>>();
 
@@ -2236,7 +2236,7 @@ mod tests {
         };
 
         let hashes = subscriptions
-            .queries_for_table_update(&table_update, &|_, _| None)
+            .queries_for_table_update(&table_update, |_, _| None)
             .cloned()
             .collect::<Vec<_>>();
 
@@ -2252,7 +2252,7 @@ mod tests {
         };
 
         let hashes = subscriptions
-            .queries_for_table_update(&table_update, &|_, _| None)
+            .queries_for_table_update(&table_update, |_, _| None)
             .cloned()
             .collect::<Vec<_>>();