Migrate to Rust 2024 #3802
Open
Migrate to Rust 2024 #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
coolreader18
force-pushed
the
noa/rust-2024
branch
3 times, most recently
from
995eff3 to
75c9f51
Compare
Keep rustfmt.toml style_edition on 2021
coolreader18
force-pushed
the
noa/rust-2024
branch
from
75c9f51 to
41044c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
It'd be best to review this commit-by-commit, and using difftastic to easily tell when changes are minor in terms of syntax but a line based diff doesn't show that.
Expected complexity level and risk
3 - edition2024 does bring changes to drop order, which could cause issues with locks, but I looked through all of the warnings that weren't fixed automatically and couldn't find any issues.
Testing
n/a; internal code change