feat(roles): enable correct pagination parameters (#2398)

Author: stainless-app[bot]

.stats.yml

@@ -1,2 +1,2 @@
 configured_endpoints: 1525
-openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-e4e4fe20b25c825f2c21322b8909758f1a84f25cfe0df7ce34571b8a2f2be1c1.yml
+openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-4c85e60ad7ca96a7ddadf88e1e3c7b62fb791d39d435bedfe6caac2c27081a48.yml

api.md

@@ -61,7 +61,7 @@ Methods:
 
 Methods:
 
-- <code title="get /accounts/{account_id}/roles">client.accounts.roles.<a href="./src/resources/accounts/roles.ts">list</a>({ ...params }) -> RolesSinglePage</code>
+- <code title="get /accounts/{account_id}/roles">client.accounts.roles.<a href="./src/resources/accounts/roles.ts">list</a>({ ...params }) -> RolesV4PagePaginationArray</code>
 - <code title="get /accounts/{account_id}/roles/{role_id}">client.accounts.roles.<a href="./src/resources/accounts/roles.ts">get</a>(roleId, { ...params }) -> Role</code>
 
 ## Subscriptions

src/resources/accounts/roles.ts

@@ -3,7 +3,8 @@
 import { APIResource } from '../../resource';
 import * as Core from '../../core';
 import * as Shared from '../shared';
-import { RolesSinglePage } from '../shared';
+import { RolesV4PagePaginationArray } from '../shared';
+import { type V4PagePaginationArrayParams } from '../../pagination';
 
 export class Roles extends APIResource {
   /**
@@ -12,9 +13,12 @@ export class Roles extends APIResource {
   list(
     params: RoleListParams,
     options?: Core.RequestOptions,
-  ): Core.PagePromise<RolesSinglePage, Shared.Role> {
-    const { account_id } = params;
-    return this._client.getAPIList(`/accounts/${account_id}/roles`, RolesSinglePage, options);
+  ): Core.PagePromise<RolesV4PagePaginationArray, Shared.Role> {
+    const { account_id, ...query } = params;
+    return this._client.getAPIList(`/accounts/${account_id}/roles`, RolesV4PagePaginationArray, {
+      query,
+      ...options,
+    });
   }
 
   /**
@@ -30,9 +34,9 @@ export class Roles extends APIResource {
   }
 }
 
-export interface RoleListParams {
+export interface RoleListParams extends V4PagePaginationArrayParams {
   /**
-   * Account identifier tag.
+   * Path param: Account identifier tag.
    */
   account_id: string;
 }
@@ -48,4 +52,4 @@ export declare namespace Roles {
   export { type RoleListParams as RoleListParams, type RoleGetParams as RoleGetParams };
 }
 
-export { RolesSinglePage };
+export { RolesV4PagePaginationArray };

src/resources/shared.ts

@@ -953,7 +953,7 @@ export type TokenValue = string;
 
 export class MembersV4PagePaginationArray extends V4PagePaginationArray<Member> {}
 
-export class RolesSinglePage extends SinglePage<Role> {}
+export class RolesV4PagePaginationArray extends V4PagePaginationArray<Role> {}
 
 export class SubscriptionsSinglePage extends SinglePage<Subscription> {}
 

tests/api-resources/accounts/roles.test.ts

@@ -22,7 +22,11 @@ describe('resource roles', () => {
   });
 
   test('list: required and optional params', async () => {
-    const response = await client.accounts.roles.list({ account_id: 'eb78d65290b24279ba6f44721b3ea3c4' });
+    const response = await client.accounts.roles.list({
+      account_id: 'eb78d65290b24279ba6f44721b3ea3c4',
+      page: 1,
+      per_page: 5,
+    });
   });
 
   test('get: only required params', async () => {