Skip to content

This worker template's "dev" script is not OS-independent, fails to run on Windows #36

@GavinRay97

Description

@GavinRay97

Prefixing commands with environment variables only works on *nix, because Windows is awful
So your templates won't run for Windows folks

$ yarn dev
yarn run v1.22.10
$ NODE_ENV=development npm run build
'NODE_ENV' is not recognized as an internal or external command, operable program or batch file.
error Command failed with exit code 1.

The equivalent for Windows is SET NODE_ENV=development & npm run build
But it would be a cleaner/less hacky solution probably to use cross-env, because of whatever weird edgecase stuff may pop up:

https://github.com/kentcdodds/cross-env

cross-env NODE_ENV=development npm run build

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions