diff --git a/.changeset/polite-apples-invent.md b/.changeset/polite-apples-invent.md new file mode 100644 index 0000000000..bc8d9bdb7e --- /dev/null +++ b/.changeset/polite-apples-invent.md @@ -0,0 +1,8 @@ +--- +"@cloudoperators/juno-messages-provider": patch +"@cloudoperators/juno-app-greenhouse": patch +"@cloudoperators/juno-app-supernova": patch +"@cloudoperators/juno-app-doop": patch +--- + +Removes unused variables, imports, functions, and classes identified by static code analysis to improve code quality and maintainability. diff --git a/apps/doop/src/App.tsx b/apps/doop/src/App.tsx index cc105d2b1e..b33ba1a880 100644 --- a/apps/doop/src/App.tsx +++ b/apps/doop/src/App.tsx @@ -5,7 +5,7 @@ import React, { StrictMode, useLayoutEffect } from "react" -import { AppShellProvider, ContentHeading } from "@cloudoperators/juno-ui-components" +import { AppShellProvider } from "@cloudoperators/juno-ui-components" import { RouterProvider, createBrowserHistory, createHashHistory, createRouter } from "@tanstack/react-router" import { decodeV2, encodeV2, registerConsumer } from "@cloudoperators/juno-url-state-provider" import styles from "./styles.css?inline" diff --git a/apps/doop/src/routes/violations.tsx b/apps/doop/src/routes/violations.tsx index 217f2251bd..a77359f553 100644 --- a/apps/doop/src/routes/violations.tsx +++ b/apps/doop/src/routes/violations.tsx @@ -4,7 +4,7 @@ */ import React, { useLayoutEffect } from "react" -import { createFileRoute, retainSearchParams } from "@tanstack/react-router" +import { createFileRoute } from "@tanstack/react-router" import { z } from "zod" import AppContent from "../components/AppContent" import { convertUrlStateToAppState, getFiltersForUrl } from "../lib/urlStateUtils" diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/clusters/store.test.ts b/apps/greenhouse/src/components/core-apps/org-admin/components/clusters/store.test.ts index 627001624a..42219cd6bc 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/clusters/store.test.ts +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/clusters/store.test.ts @@ -44,8 +44,6 @@ describe("store tests", () => { }) describe("Modify Cluster", () => { - const version = "greenhouse.sap/v1alpha1" - test("check valid modification", () => { const { result } = renderHook(() => useStore()) act(() => { diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/KeyValueInput.tsx b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/KeyValueInput.tsx index ce22871873..b255983a93 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/KeyValueInput.tsx +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/KeyValueInput.tsx @@ -5,7 +5,7 @@ import React from "react" -import { Button, Stack, TextInput, FormSection, InputGroup, FormRow } from "@cloudoperators/juno-ui-components" +import { Button, TextInput, FormSection, InputGroup, FormRow } from "@cloudoperators/juno-ui-components" /* * This Element provides a form section for entering and editing key-value pairs. * The key-value data and the setData function are passed as props. diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/PluginEdit.tsx b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/PluginEdit.tsx index 9bc2b8d9b4..7150918782 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/PluginEdit.tsx +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/PluginEdit.tsx @@ -42,7 +42,6 @@ interface PluginEditProps { } const PluginEdit: React.FC = (props: PluginEditProps) => { const namespace = useStore((state: any) => state.namespace) - const showEditForm = useStore((state: any) => state.showEditForm) const setShowEditForm = useStore((state: any) => state.setShowEditForm) const editFormState = useStore((state: any) => state.editFormState) @@ -148,10 +147,6 @@ const PluginEdit: React.FC = (props: PluginEditProps) => { const kindName = isPluginPreset ? "Plugin Preset" : "Plugin" - const onPanelClose = () => { - setShowEditForm(false) - } - const [submitMessage, setSubmitResultMessage] = React.useState({ message: "", ok: false }) const onSubmit = async () => { if (isPluginPreset) { diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/SecretKeySelect.tsx b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/SecretKeySelect.tsx index ffbece5433..fb9bd4f463 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/SecretKeySelect.tsx +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/SecretKeySelect.tsx @@ -4,7 +4,7 @@ */ import React from "react" -import { PluginOptionValueFrom, Secret, SecretDataEntry } from "../../../types/types" +import { PluginOptionValueFrom } from "../../../types/types" import { Stack, Select, SelectOption } from "@cloudoperators/juno-ui-components" import usePluginDefinitionsStore from "../plugindefinitions/store" diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/handleFormChange.ts b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/handleFormChange.ts index 9248246787..66e369c485 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/handleFormChange.ts +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/handleFormChange.ts @@ -3,7 +3,7 @@ * SPDX-License-Identifier: Apache-2.0 */ -import { Plugin, PluginOptionValue, Secret, SecretDataEntry } from "../../../types/types" +import { PluginOptionValue } from "../../../types/types" import { EditFormData } from "../plugindefinitions/store" const handleFormChange = (e: React.ChangeEvent, editFormData: EditFormData): EditFormData => { diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/components/PluginDefinitionDetail.tsx b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/components/PluginDefinitionDetail.tsx index 4d1f512871..fac129ac23 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/components/PluginDefinitionDetail.tsx +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/components/PluginDefinitionDetail.tsx @@ -12,9 +12,6 @@ import { DataGridHeadCell, DataGridRow, DataGridToolbar, - Panel, - PanelBody, - Stack, } from "@cloudoperators/juno-ui-components" import React, { useEffect } from "react" import ReactMarkDown from "react-markdown" @@ -34,7 +31,6 @@ interface PluginDefinitionDetailProps { } const PluginDefinitionDetail: React.FC = (props: PluginDefinitionDetailProps) => { - const showPluginDefinitionDetails = useStore((state: any) => state.showPluginDefinitionDetails) const setShowPluginDefinitionDetails = useStore((state: any) => state.setShowPluginDefinitionDetails) const setShowPluginDefinitionEdit = useStore((state: any) => state.setShowEditForm) @@ -43,7 +39,6 @@ const PluginDefinitionDetail: React.FC = (props: Pl const { getPluginsByLabelSelector: getPluginsByLabelSelector } = usePluginApi() const { fetchMarkDown: fetchMarkDown } = useFetchMarkDown() - const setIsEditMode = useStore((state: any) => state.setIsPluginEditMode) const setEditFormData = useStore((state: any) => state.setEditFormData) const setEditFormState = useStore((state: any) => state.setEditFormState) diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/hooks/useApi.ts b/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/hooks/useApi.ts index 6bf3fad156..8c0e0d3b02 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/hooks/useApi.ts +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/hooks/useApi.ts @@ -17,8 +17,6 @@ export const useApi = (debug?: boolean) => { const get = useCallback( async (url: string, object: T, params?: any): Promise => { - let response: T - if (!client || !namespace) { return { ok: false, message: "Client or namespace not available" } } diff --git a/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/store.ts b/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/store.ts index 3c25b3e2de..f81290db9a 100644 --- a/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/store.ts +++ b/apps/greenhouse/src/components/core-apps/org-admin/components/secrets/store.ts @@ -95,19 +95,4 @@ const useStore = create((set: any) => ({ })), })) -const updateSecrets = (existingSecrets: Secret[], newSecrets: Secret[]): Secret[] => { - let returnSecrets = existingSecrets - newSecrets.forEach((inputSecret) => { - const index = existingSecrets.findIndex((knownSecret: any) => { - return knownSecret.metadata!.name === inputSecret.metadata!.name - }) - if (index >= 0) { - returnSecrets[index] = inputSecret - } else { - returnSecrets.push(inputSecret) - } - }) - return returnSecrets -} - export default useStore diff --git a/apps/supernova/src/App.tsx b/apps/supernova/src/App.tsx index 51017a736e..f8522bfe0a 100644 --- a/apps/supernova/src/App.tsx +++ b/apps/supernova/src/App.tsx @@ -15,7 +15,6 @@ import styles from "./styles.css?inline" import { StoreProvider } from "./components/StoreProvider" import { routeTree } from "./routeTree.gen" import { convertAppStateToUrlState, extractSearchStringFromHashFragment, readLegacyUrlState } from "./lib/urlStateUtils" -import { isObjectWithKeys } from "./lib/utils" // Create a new router instance const router = createRouter({ diff --git a/apps/supernova/src/components/StoreProvider.tsx b/apps/supernova/src/components/StoreProvider.tsx index 919a9cd80f..f2ebf346a2 100644 --- a/apps/supernova/src/components/StoreProvider.tsx +++ b/apps/supernova/src/components/StoreProvider.tsx @@ -5,7 +5,6 @@ import React, { createContext, useContext } from "react" import { createStore, useStore, StoreApi } from "zustand" -import { devtools } from "zustand/middleware" import createSilencesSlice, { SilencesSlice } from "../lib/createSilencesSlice" import createAlertsSlice, { AlertsSlice } from "../lib/createAlertsSlice" diff --git a/packages/messages-provider/src/useMessageStore.test.tsx b/packages/messages-provider/src/useMessageStore.test.tsx index f79f2e72e2..a22f24fbc2 100644 --- a/packages/messages-provider/src/useMessageStore.test.tsx +++ b/packages/messages-provider/src/useMessageStore.test.tsx @@ -4,7 +4,7 @@ */ import * as React from "react" -import { renderHook, act, waitFor } from "@testing-library/react" +import { renderHook, act } from "@testing-library/react" import { useMessages, useActions, MessagesProvider } from "./index" const originalConsoleError = global.console.error