tweak null check

cmgmyr · cmgmyr · commit cfd3f5acb1ca · 2019-05-31T14:38:47.000-04:00
diff --git a/src/Models/Thread.php b/src/Models/Thread.php
@@ -142,12 +142,11 @@ public static function getBySubject($subject)
      */
     public function participantsUserIds($userId = null)
     {
-        /** @var \Illuminate\Support\Collection $users */
         $users = $this->participants()->withTrashed()->select('user_id')->get()->map(function ($participant) {
             return $participant->user_id;
         });
 
-        if ($userId) {
+        if ($userId !== null) {
             $users->push($userId);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -142,12 +142,11 @@ public static function getBySubject($subject)`
`142`	`142`	`*/`
`143`	`143`	`public function participantsUserIds($userId = null)`
`144`	`144`	`{`
`145`		`- /** @var \Illuminate\Support\Collection $users */`
`146`	`145`	`$users = $this->participants()->withTrashed()->select('user_id')->get()->map(function ($participant) {`
`147`	`146`	`return $participant->user_id;`
`148`	`147`	`});`
`149`	`148`
`150`		`- if ($userId) {`
	`149`	`+ if ($userId !== null) {`
`151`	`150`	`$users->push($userId);`
`152`	`151`	`}`
`153`	`152`