Skip to content

Commit 2b330b3

Browse files
committed
kvserver: partially clarify StoreIdentKey
Epic: none Release note: none
1 parent f75aa16 commit 2b330b3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pkg/cli/debug_recover_loss_of_quorum.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,7 @@ func applyRecoveryToLocalStore(
825825
defer store.Close() //nolint:deferloop
826826
defer batch.Close() //nolint:deferloop
827827

828+
// TODO(sep-raft-log): StoreIdent is in the LogEngine.
828829
storeIdent, err := kvstorage.ReadStoreIdent(ctx, store)
829830
if err != nil {
830831
return err
@@ -844,6 +845,7 @@ func applyRecoveryToLocalStore(
844845
}
845846

846847
updateTime := timeutil.Now()
848+
// TODO(sep-raft-log): batches need to work with the split log/state engines.
847849
prepReport, err := loqrecovery.PrepareUpdateReplicas(
848850
ctx, nodeUpdates, uuid.DefaultGenerator, updateTime, localNodeID, batches)
849851
if err != nil {

pkg/kv/kvserver/store.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2147,8 +2147,7 @@ func (s *Store) Start(ctx context.Context, stopper *stop.Stopper) error {
21472147

21482148
// Populate the store ident. If not bootstrapped, ReadStoreIntent will
21492149
// return an error.
2150-
// TODO(sep-raft-log): which engine holds the ident?
2151-
ident, err := kvstorage.ReadStoreIdent(ctx, s.TODOEngine())
2150+
ident, err := kvstorage.ReadStoreIdent(ctx, s.LogEngine())
21522151
if err != nil {
21532152
return err
21542153
}

0 commit comments

Comments
 (0)