Merge #153469 #158393

153469: opt: remove outdated hint for unknown functions in views r=mgartner a=anuj-agrawal-0705

Fixes #151685

Release note: None


158393: mmaprototype: extract relationship building between voter and all-replica constraints r=wenyihu6 a=wenyihu6

Based on top of #158333. 

Epic: CRDB-55052 
Release note: none

---
**mmaprototype: extract relationship building between voter and all-replica constraints**




Co-authored-by: Anuj <anujagrawal0705@gmail.com>
Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com>

Author: 3 people

pkg/cmd/roachtest/testdata/pg_regress/aggregates.diffs

@@ -1597,7 +1597,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
    select aggfns(a,b,c)
      from (values (1,3,'foo'),(0,null,null),(2,2,'bar'),(3,1,'baz')) v(a,b,c);
 +ERROR:  unknown function: aggfns()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from agg_view1;
 -                    aggfns                     
 ------------------------------------------------
@@ -1618,7 +1617,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
      from (values (1,3,'foo'),(0,null,null),(2,2,'bar'),(3,1,'baz')) v(a,b,c),
           generate_series(1,3) i;
 +ERROR:  unknown function: aggfns()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from agg_view1;
 -                    aggfns                     
 ------------------------------------------------
@@ -1664,7 +1662,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
    select aggfns(a,b,c order by b+1)
      from (values (1,3,'foo'),(0,null,null),(2,2,'bar'),(3,1,'baz')) v(a,b,c);
 +ERROR:  unknown function: aggfns()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from agg_view1;
 -                    aggfns                     
 ------------------------------------------------
@@ -1684,7 +1681,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/aggregates.out --
    select aggfns(a,a,c order by b)
      from (values (1,3,'foo'),(0,null,null),(2,2,'bar'),(3,1,'baz')) v(a,b,c);
 +ERROR:  unknown function: aggfns()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from agg_view1;
 -                     aggfns                     
 -------------------------------------------------

pkg/cmd/roachtest/testdata/pg_regress/alter_table.diffs

@@ -3976,7 +3976,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/alter_table.out -
  and c.relname != 'my_locks'
  group by c.relname;
 +ERROR:  unknown function: pg_current_xact_id()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  create table alterlock (f1 int primary key, f2 text);
  insert into alterlock values (1, 'foo');
  create table alterlock2 (f3 int primary key, f1 int);
@@ -4205,7 +4204,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/alter_table.out -
  and c.relname = 'my_locks'
  group by c.relname;
 +ERROR:  unknown function: pg_current_xact_id()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  -- raise exception
  alter table my_locks set (autovacuum_enabled = false);
 -ERROR:  unrecognized parameter "autovacuum_enabled"

pkg/cmd/roachtest/testdata/pg_regress/create_view.diffs

@@ -2061,7 +2061,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/create_view.out -
 +
  create view tt14v as select t.* from tt14f() t;
 +ERROR:  unknown function: tt14f()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select pg_get_viewdef('tt14v', true);
 -         pg_get_viewdef         
 ---------------------------------
@@ -2185,7 +2184,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/create_view.out -
 +ERROR:  relation "tt14v" does not exist
  create view tt14v as select t.f1, t.f4 from tt14f() t;
 +ERROR:  unknown function: tt14f()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select pg_get_viewdef('tt14v', true);
 -         pg_get_viewdef         
 ---------------------------------

pkg/cmd/roachtest/testdata/pg_regress/plpgsql.diffs

@@ -635,7 +635,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/plpgsql.out --lab
  	pslot_slotlink_view(PF.slotname) as patch
      from PSlot PF;
 +ERROR:  unknown function: pslot_backlink_view()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  --
  -- First we build the house - so we create the rooms
  --

pkg/cmd/roachtest/testdata/pg_regress/privileges.diffs

@@ -3143,7 +3143,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/privileges.out --
  -- REFRESH of this MV will queue a GRANT at end of transaction
  CREATE MATERIALIZED VIEW sro_mv AS SELECT mv_action() WITH NO DATA;
 +ERROR:  unknown function: mv_action()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  REFRESH MATERIALIZED VIEW sro_mv;
 -ERROR:  cannot create a cursor WITH HOLD within security-restricted operation
 -CONTEXT:  SQL function "mv_action" statement 1

pkg/cmd/roachtest/testdata/pg_regress/rangefuncs.diffs

@@ -325,7 +325,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
 +ERROR:  unknown function: getrngfunc8()
  CREATE VIEW vw_getrngfunc AS SELECT * FROM getrngfunc8(1);
 +ERROR:  unknown function: getrngfunc8()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  SELECT * FROM vw_getrngfunc;
 - getrngfunc8 
 --------------
@@ -337,7 +336,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
 +ERROR:  relation "vw_getrngfunc" does not exist
  CREATE VIEW vw_getrngfunc AS SELECT * FROM getrngfunc8(1) WITH ORDINALITY AS t1(v,o);
 +ERROR:  unknown function: getrngfunc8()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  SELECT * FROM vw_getrngfunc;
 - v | o 
 ----+---
@@ -366,7 +364,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
 +ERROR:  unknown function: getrngfunc9()
  CREATE VIEW vw_getrngfunc AS SELECT * FROM getrngfunc9(1);
 +ERROR:  unknown function: getrngfunc9()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  SELECT * FROM vw_getrngfunc;
 - rngfuncid | rngfuncsubid | rngfuncname 
 ------------+--------------+-------------
@@ -378,7 +375,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
 +ERROR:  relation "vw_getrngfunc" does not exist
  CREATE VIEW vw_getrngfunc AS SELECT * FROM getrngfunc9(1) WITH ORDINALITY AS t1(a,b,c,o);
 +ERROR:  unknown function: getrngfunc9()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  SELECT * FROM vw_getrngfunc;
 - a | b |  c  | o 
 ----+---+-----+---
@@ -419,7 +415,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
                        getrngfunc1(1))
                  with ordinality as t1(a,b,c,d,e,f,g,n);
 +ERROR:  unknown function: getrngfunc9()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from vw_rngfunc;
 - a | b |  c  | d | e |  f  | g | n 
 ----+---+-----+---+---+-----+---+---
@@ -1906,7 +1901,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rangefuncs.out --
  create temp view usersview as
  SELECT * FROM ROWS FROM(get_users(), generate_series(10,11)) WITH ORDINALITY;
 +ERROR:  unknown function: get_users()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  select * from usersview;
 - userid | seq | email  | moredrop | enabled | generate_series | ordinality 
 ---------+-----+--------+----------+---------+-----------------+------------

pkg/cmd/roachtest/testdata/pg_regress/rules.diffs

@@ -1229,7 +1229,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/rules.out --label
  	   AND rsl.sl_len_cm >= rsh.slminlen_cm
  	   AND rsl.sl_len_cm <= rsh.slmaxlen_cm;
 +ERROR:  unknown function: int4smaller()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  INSERT INTO unit VALUES ('cm', 1.0);
  INSERT INTO unit VALUES ('m', 100.0);
  INSERT INTO unit VALUES ('inch', 2.54);

pkg/cmd/roachtest/testdata/pg_regress/xml.diffs

@@ -980,14 +980,12 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/xml_1.out --label
  -- Test backwards parsing
  CREATE VIEW xmlview1 AS SELECT xmlcomment('test');
 +ERROR:  unknown function: xmlcomment()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  CREATE VIEW xmlview2 AS SELECT xmlconcat('hello', 'you');
 -ERROR:  unsupported XML feature
 -LINE 1: CREATE VIEW xmlview2 AS SELECT xmlconcat('hello', 'you');
 -                                                 ^
 -DETAIL:  This functionality requires the server to be built with libxml support.
 +ERROR:  unknown function: xmlconcat()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  CREATE VIEW xmlview3 AS SELECT xmlelement(name element, xmlattributes (1 as ":one:", 'deuce' as two), 'content&');
 -ERROR:  unsupported XML feature
 -DETAIL:  This functionality requires the server to be built with libxml support.
@@ -1004,7 +1002,6 @@ diff -U3 --label=/mnt/data1/postgres/src/test/regress/expected/xml_1.out --label
 +                                               ^
  CREATE VIEW xmlview5 AS SELECT xmlparse(content '<abc>x</abc>');
 +ERROR:  unknown function: xmlparse()
-+HINT:  There is probably a typo in function name. Or the intention was to use a user-defined function in the view query, which is currently not supported.
  CREATE VIEW xmlview6 AS SELECT xmlpi(name foo, 'bar');
 -ERROR:  unsupported XML feature
 -DETAIL:  This functionality requires the server to be built with libxml support.