Merge #158095 #158287

158095: sql: add logic tests for `ALTER TABLE ALTER COLUMN` identity options r=bghal a=bghal

The tests were incomplete. These options aren't supported so this is
for consistency between the legacy and declarative schema changers.

Epic: CRDB-31283
Part of: #142914

Release note: None


158287: sql: add tests for updated value on ALTER TABLE identity r=bghal a=bghal

The changes in #154489 addressed inconsistencies with PG sequence
manipulation (the `ALTER SEQUENCE` commands didn't correctly update the
current value).
Those changes weren't applied to `ALTER TABLE ALTER COLUMN`.
This change describes the current behavior to ensure consistency
when #157030 is merged.

Part of: #142914
Epic: CRDB-31283
Informs: #52552
Informs: #21564

Release note: None


Co-authored-by: Brendan Gerrity <brendan.gerrity@cockroachlabs.com>

Author: craig[bot]

pkg/sql/logictest/testdata/logic_test/alter_sequence

@@ -400,7 +400,7 @@ subtest issue-52552
 
 statement ok
 CREATE SEQUENCE test_52552_asc INCREMENT BY 3 MINVALUE 1 MAXVALUE 12;
-ALTER SEQUENCE test_52552_asc INCREMENT BY 8 MINVALUE 1 MAXVALUE 12;
+ALTER SEQUENCE test_52552_asc INCREMENT BY 8;
 
 query II
 SELECT nextval('test_52552_asc'), nextval('test_52552_asc');
@@ -423,7 +423,7 @@ SELECT nextval('test_52552_asc');
 
 statement ok
 CREATE SEQUENCE test_52552_desc INCREMENT BY -5 MINVALUE 1 MAXVALUE 12;
-ALTER SEQUENCE test_52552_desc INCREMENT BY -8 MINVALUE 1 MAXVALUE 12;
+ALTER SEQUENCE test_52552_desc INCREMENT BY -8;
 
 query II
 SELECT nextval('test_52552_desc'), nextval('test_52552_desc');

pkg/sql/logictest/testdata/logic_test/alter_table

@@ -4439,6 +4439,81 @@ SELECT b from t_alter_identity ORDER BY b;
 20
 22
 
+subtest issue-52552
+
+statement ok
+CREATE TABLE test_52552_asc (c1 int GENERATED ALWAYS AS IDENTITY);
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET INCREMENT BY 3 SET MINVALUE 1 SET MAXVALUE 12 RESTART;
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET INCREMENT BY 8;
+INSERT INTO test_52552_asc DEFAULT VALUES;
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+query I rowsort
+SELECT c1 FROM test_52552_asc
+----
+9
+1
+
+statement error pq: reached maximum value of sequence "test_52552_asc_c1_seq"
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+statement error pq: reached maximum value of sequence "test_52552_asc_c1_seq"
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+statement ok
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET NO MAXVALUE;
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+query I rowsort
+SELECT c1 FROM test_52552_asc
+----
+1
+9
+17
+
+statement ok
+CREATE TABLE test_52552_desc (c1 int GENERATED ALWAYS AS IDENTITY);
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET INCREMENT BY -5 SET MINVALUE 1 SET MAXVALUE 12 SET START 12 RESTART;
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET INCREMENT BY -8;
+INSERT INTO test_52552_desc DEFAULT VALUES;
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+query I rowsort
+SELECT c1 FROM test_52552_desc
+----
+12
+4
+
+statement error pq: reached minimum value of sequence "test_52552_desc_c1_seq" \(1\)
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+statement error pq: reached minimum value of sequence "test_52552_desc_c1_seq" \(1\)
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+statement ok
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET NO MINVALUE;
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+query I rowsort
+SELECT c1 FROM test_52552_desc
+----
+12
+4
+-4
+
+statement ok
+CREATE TABLE test_52552_start (c1 int GENERATED ALWAYS AS IDENTITY);
+ALTER TABLE test_52552_start ALTER COLUMN c1 SET INCREMENT 3 SET MINVALUE 1 SET MAXVALUE 100 SET START 50;
+ALTER TABLE test_52552_start ALTER COLUMN c1 SET INCREMENT 8;
+INSERT INTO test_52552_start DEFAULT VALUES;
+
+query I
+SELECT c1 FROM test_52552_start;
+----
+50
+
+subtest end
+
 statement ok
 CREATE TABLE t_identity_drop (a int GENERATED ALWAYS AS IDENTITY (START WITH 10), b int GENERATED BY DEFAULT AS IDENTITY);