Skip to content

Commit cd899f9

Browse files
craig[bot]stevendanna
andcommitted
Merge #158261
158261: roachtest: set ulimit for TPC-E workload runner r=herkolategan a=stevendanna A recent version upgrade of docker changed the default of LimitNOFILE: > containerd v2.1.5 now uses systemd's default LimitNOFILE for containers, > changing the open file descriptor limit (ulimit -n) from 1048576 to 1024. This > extends a change introduced in Docker Engine v25.0 for build containers to all > containers. Here, I explicitly set the `ulimit` when launcing the container. According to the release note, an alternative here is to update our docker configuration on install: ``` { "default-ulimits": { "nofile": { "Name": "nofile", "Soft": 1048576, "Hard": 1048576 } } } ``` Fixes #158243 Release note: None Co-authored-by: Steven Danna <danna@cockroachlabs.com>
2 parents e3829a0 + d36b7b6 commit cd899f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/cmd/roachtest/tests/tpce.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func initTPCESpec(ctx context.Context, l *logger.Logger, c cluster.Cluster) (*tp
105105
}
106106

107107
func (ts *tpceSpec) newCmd(o tpceCmdOptions) *roachtestutil.Command {
108-
cmd := roachtestutil.NewCommand(`sudo docker run us-east1-docker.pkg.dev/crl-ci-images/cockroach/tpc-e:master`)
108+
cmd := roachtestutil.NewCommand(`sudo docker run --ulimit nofile=1048576 us-east1-docker.pkg.dev/crl-ci-images/cockroach/tpc-e:master`)
109109
o.AddCommandOptions(cmd)
110110
return cmd
111111
}

0 commit comments

Comments
 (0)