Skip to content

Commit e36b316

Browse files
author
Obada Haddad
committed
fix missing needs: to make the push job wait for the build to finish first
1 parent dc1bc4d commit e36b316

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

.github/workflows/build_cw_image-branch.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
push:
2323
name: Push image to Dockerhub
2424
runs-on: ubuntu-latest
25+
needs: [build]
2526
steps:
2627
- name: Login to Docker Hub
2728
uses: docker/login-action@v3

.github/workflows/build_cw_image-dev.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
push:
2020
name: Push image to Dockerhub
2121
runs-on: ubuntu-latest
22+
needs: [build]
2223
steps:
2324
- name: Login to Docker Hub
2425
uses: docker/login-action@v3

.github/workflows/build_cw_image-prod.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
push:
2020
name: Push image to Dockerhub
2121
runs-on: ubuntu-latest
22+
needs: [build]
2223
steps:
2324
- name: Login to Docker Hub
2425
uses: docker/login-action@v3

compute_worker/compute_worker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,10 +304,10 @@ def alarm_handler(signum, frame):
304304

305305
# -----------------------------------------------
306306
# Class Run
307-
# Respnosible for running a submission inside a docker container
307+
# Responsible for running a submission inside a docker/podman container
308308
# -----------------------------------------------
309309
class Run:
310-
"""A "Run" in Codalab is composed of some program, some data to work with, and some signed URLs to upload results
310+
"""A "Run" in Codabench is composed of some program, some data to work with, and some signed URLs to upload results
311311
to. There is also a secret key to do special commands for just this submission.
312312
313313
Some example API's you can hit using this secret key are:

0 commit comments

Comments
 (0)