feat: update base SDK to 10.12

codebytere · codebytere · commit 16788bcca544 · 2020-04-18T15:17:00.000-07:00
diff --git a/binding.gyp b/binding.gyp
@@ -18,7 +18,7 @@
     ],
     'defines': [ 'NAPI_DISABLE_CPP_EXCEPTIONS' ],
     "xcode_settings": {
-      "OTHER_CPLUSPLUSFLAGS": ["-std=c++14", "-stdlib=libc++", "-mmacosx-version-min=10.8"],
+      "OTHER_CPLUSPLUSFLAGS": ["-std=c++14", "-stdlib=libc++", "-mmacosx-version-min=10.12"],
       "OTHER_LDFLAGS": ["-framework CoreFoundation -framework AppKit -framework Contacts"]
     }
   }]
diff --git a/contacts.mm b/contacts.mm
@@ -251,7 +251,7 @@
 
   NSCalendar *cal = [NSCalendar currentCalendar];
   unsigned unitFlags =
-      NSYearCalendarUnit | NSMonthCalendarUnit | NSDayCalendarUnit;
+      NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay;
   NSDateComponents *birthday_components = [cal components:unitFlags
                                                  fromDate:bday_date];
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`],`
`19`	`19`	`'defines': [ 'NAPI_DISABLE_CPP_EXCEPTIONS' ],`
`20`	`20`	`"xcode_settings": {`
`21`		`- "OTHER_CPLUSPLUSFLAGS": ["-std=c++14", "-stdlib=libc++", "-mmacosx-version-min=10.8"],`
	`21`	`+ "OTHER_CPLUSPLUSFLAGS": ["-std=c++14", "-stdlib=libc++", "-mmacosx-version-min=10.12"],`
`22`	`22`	`"OTHER_LDFLAGS": ["-framework CoreFoundation -framework AppKit -framework Contacts"]`
`23`	`23`	`}`
`24`	`24`	`}]`