chore: improve linting

Author: codebytere

.github/workflows/lint.yml

@@ -0,0 +1,23 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: macOS-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: Use Node.js 12.x
+      uses: actions/setup-node@v1
+      with:
+        version: 12.x
+    - name: Lint
+      run: |
+        npm install
+        npm run lint

.github/workflows/nodejs.yml

@@ -1,6 +1,12 @@
 name: Test
 
-on: [push]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
 
 jobs:
   build:

.prettierrc

@@ -0,0 +1,8 @@
+{
+  "trailingComma": "all",
+  "tabWidth": 2,
+  "semi": false,
+  "singleQuote": true,
+  "printWidth": 100,
+  "endOfLine": "lf"
+}

index.js

@@ -17,11 +17,16 @@ function addNewContact(contact) {
     const hasPhoneNumbers = contact.hasOwnProperty('phoneNumbers')
     const hasEmailAddresses = contact.hasOwnProperty('emailAddresses')
 
-    if (hasFirstName && typeof contact.firstName !== 'string') throw new TypeError('firstName must be a string')
-    if (hasLastName && typeof contact.lastName !== 'string') throw new TypeError('lastName must be a string')
-    if (hasNickname && typeof contact.nickname !== 'string') throw new TypeError('nickname must be a string')
-    if (hasPhoneNumbers && !Array.isArray(contact.phoneNumbers)) throw new TypeError('phoneNumbers must be an array')
-    if (hasEmailAddresses && !Array.isArray(contact.emailAddresses)) throw new TypeError('emailAddresses must be an array')
+    if (hasFirstName && typeof contact.firstName !== 'string')
+      throw new TypeError('firstName must be a string')
+    if (hasLastName && typeof contact.lastName !== 'string')
+      throw new TypeError('lastName must be a string')
+    if (hasNickname && typeof contact.nickname !== 'string')
+      throw new TypeError('nickname must be a string')
+    if (hasPhoneNumbers && !Array.isArray(contact.phoneNumbers))
+      throw new TypeError('phoneNumbers must be an array')
+    if (hasEmailAddresses && !Array.isArray(contact.emailAddresses))
+      throw new TypeError('emailAddresses must be an array')
 
     if (hasBirthday) {
       const datePattern = /^\d{4}\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])$/
@@ -47,11 +52,16 @@ function updateContact(contact) {
     const hasPhoneNumbers = contact.hasOwnProperty('phoneNumbers')
     const hasEmailAddresses = contact.hasOwnProperty('emailAddresses')
 
-    if (hasFirstName && typeof contact.firstName !== 'string') throw new TypeError('firstName must be a string')
-    if (hasLastName && typeof contact.lastName !== 'string') throw new TypeError('lastName must be a string')
-    if (hasNickname && typeof contact.nickname !== 'string') throw new TypeError('nickname must be a string')
-    if (hasPhoneNumbers && !Array.isArray(contact.phoneNumbers)) throw new TypeError('phoneNumbers must be an array')
-    if (hasEmailAddresses && !Array.isArray(contact.emailAddresses)) throw new TypeError('emailAddresses must be an array')
+    if (hasFirstName && typeof contact.firstName !== 'string')
+      throw new TypeError('firstName must be a string')
+    if (hasLastName && typeof contact.lastName !== 'string')
+      throw new TypeError('lastName must be a string')
+    if (hasNickname && typeof contact.nickname !== 'string')
+      throw new TypeError('nickname must be a string')
+    if (hasPhoneNumbers && !Array.isArray(contact.phoneNumbers))
+      throw new TypeError('phoneNumbers must be an array')
+    if (hasEmailAddresses && !Array.isArray(contact.emailAddresses))
+      throw new TypeError('emailAddresses must be an array')
 
     if (hasBirthday) {
       const datePattern = /^\d{4}\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])$/
@@ -78,5 +88,5 @@ module.exports = {
   getContactsByName,
   addNewContact,
   deleteContact,
-  updateContact
-}
+  updateContact,
+}

package-lock.json

@@ -6,7 +6,8 @@
   "scripts": {
     "build": "node-gyp rebuild",
     "clean": "node-gyp clean",
-    "format": "clang-format -i contacts.mm",
+    "lint": "prettier --check index.js",
+    "format": "clang-format -i contacts.mm && prettier --write index.js",
     "test": "./node_modules/.bin/mocha --reporter spec"
   },
   "repository": {
@@ -30,7 +31,8 @@
     "chai": "^4.2.0",
     "clang-format": "^1.3.0",
     "mocha": "^6.2.0",
-    "node-gyp": "^5.0.3"
+    "node-gyp": "^5.0.3",
+    "prettier": "^2.0.4"
   },
   "dependencies": {
     "bindings": "^1.5.0",