Skip to content

Commit 417581e

Browse files
author
Codeflash Bot
committed
minor bug fix
1 parent 9502f59 commit 417581e

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

codeflash/api/aiservice.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import os
55
import platform
66
import time
7-
from pathlib import Path
87
from typing import TYPE_CHECKING, Any, cast
98

109
import requests
@@ -24,6 +23,8 @@
2423
from codeflash.version import __version__ as codeflash_version
2524

2625
if TYPE_CHECKING:
26+
from pathlib import Path
27+
2728
from codeflash.discovery.functions_to_optimize import FunctionToOptimize
2829
from codeflash.models.ExperimentMetadata import ExperimentMetadata
2930
from codeflash.models.models import AIServiceRefinerRequest
@@ -559,7 +560,6 @@ def get_optimization_review(
559560
replay_tests: str,
560561
concolic_tests: str, # noqa: ARG002
561562
calling_fn_details: str,
562-
project_root_dir: Path,
563563
) -> str:
564564
"""Compute the optimization review of current Pull Request.
565565
@@ -584,18 +584,13 @@ def get_optimization_review(
584584
"""
585585
diff_str = "\n".join(
586586
[
587-
unified_diff_strings(
588-
code1=original_code[p],
589-
code2=new_code[p],
590-
fromfile=Path(p).relative_to(project_root_dir).as_posix(),
591-
tofile=Path(p).relative_to(project_root_dir).as_posix(),
592-
)
587+
unified_diff_strings(code1=original_code[p], code2=new_code[p])
593588
for p in original_code
594589
if not is_zero_diff(original_code[p], new_code[p])
595590
]
596591
)
597592
code_diff = f"```diff\n{diff_str}\n```"
598-
logger.info("!lsp|Reviewing Optimization…")
593+
logger.info("loading|Reviewing Optimization…")
599594
payload = {
600595
"code_diff": code_diff,
601596
"explanation": explanation.raw_explanation_message,

codeflash/lsp/features/perform_optimization.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,5 +134,5 @@ def sync_perform_optimization(server: CodeflashLanguageServer, cancel_event: thr
134134
"patch_file": str(patch_path),
135135
"task_id": params.task_id,
136136
"explanation": best_optimization.explanation_v2,
137-
"optimizationReview": function_optimizer.optimization_review,
137+
"optimizationReview": function_optimizer.optimization_review.capitalize(),
138138
}

codeflash/optimization/function_optimizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1506,7 +1506,7 @@ def process_review(
15061506
# this will now run regardless of pr, staging review flags
15071507
try:
15081508
opt_review_response = self.aiservice_client.get_optimization_review(
1509-
**data, calling_fn_details=function_references, project_root_dir=self.project_root
1509+
**data, calling_fn_details=function_references
15101510
)
15111511
except Exception as e:
15121512
logger.debug(f"optimization review response failed, investigate {e}")

0 commit comments

Comments
 (0)