code_review

Author: KRRT7

codeflash/verification/test_runner.py

@@ -36,20 +36,21 @@ def run_behavioral_tests(
     *,
     pytest_timeout: int | None = None,
     pytest_cmd: str = "pytest",
-    pytest_target_runtime_seconds: int = TOTAL_LOOPING_TIME_EFFECTIVE,
+    pytest_target_runtime_seconds: float = TOTAL_LOOPING_TIME_EFFECTIVE,
     enable_coverage: bool = False,
 ) -> tuple[Path, subprocess.CompletedProcess, Path | None, Path | None]:
     if test_framework in {"pytest", "unittest"}:
         test_files: list[str] = []
         for file in test_paths.test_files:
             if file.test_type == TestType.REPLAY_TEST:
                 # Replay tests need specific test targeting because one file contains tests for multiple functions
-                test_files.extend(
-                    [
-                        str(file.instrumented_behavior_file_path) + "::" + test.test_function
-                        for test in file.tests_in_file
-                    ]
-                )
+                if file.tests_in_file:
+                    test_files.extend(
+                        [
+                            str(file.instrumented_behavior_file_path) + "::" + test.test_function
+                            for test in file.tests_in_file
+                        ]
+                    )
             else:
                 test_files.append(str(file.instrumented_behavior_file_path))
         pytest_cmd_list = (
@@ -67,7 +68,7 @@ def run_behavioral_tests(
             f"--codeflash_seconds={pytest_target_runtime_seconds}",
         ]
         if pytest_timeout is not None:
-            common_pytest_args.insert(1, f"--timeout={pytest_timeout}")
+            common_pytest_args.append(f"--timeout={pytest_timeout}")
 
         result_file_path = get_run_tmp_file(Path("pytest_results.xml"))
         result_args = [f"--junitxml={result_file_path.as_posix()}", "-o", "junit_logging=all"]
@@ -163,7 +164,7 @@ def run_line_profile_tests(
             f"--codeflash_seconds={pytest_target_runtime_seconds}",
         ]
         if pytest_timeout is not None:
-            pytest_args.insert(1, f"--timeout={pytest_timeout}")
+            pytest_args.append(f"--timeout={pytest_timeout}")
         result_file_path = get_run_tmp_file(Path("pytest_results.xml"))
         result_args = [f"--junitxml={result_file_path.as_posix()}", "-o", "junit_logging=all"]
         pytest_test_env = test_env.copy()
@@ -213,7 +214,8 @@ def run_benchmarking_tests(
             f"--codeflash_seconds={pytest_target_runtime_seconds}",
         ]
         if pytest_timeout is not None:
-            pytest_args.insert(1, f"--timeout={pytest_timeout}")
+            pytest_args.append(f"--timeout={pytest_timeout}")
+
         result_file_path = get_run_tmp_file(Path("pytest_results.xml"))
         result_args = [f"--junitxml={result_file_path.as_posix()}", "-o", "junit_logging=all"]
         pytest_test_env = test_env.copy()