not needed here

Author: KRRT7

codeflash/optimization/function_optimizer.py

@@ -1269,7 +1269,7 @@ def setup_and_establish_baseline(
 
         original_code_baseline, test_functions_to_remove = baseline_result.unwrap()
         if isinstance(original_code_baseline, OriginalCodeBaseline) and (
-            not coverage_critic(original_code_baseline.coverage_results, "pytest")
+            not coverage_critic(original_code_baseline.coverage_results)
             or not quantity_of_tests_critic(original_code_baseline)
         ):
             if self.args.override_fixtures:
@@ -1629,7 +1629,7 @@ def establish_original_code_baseline(
             )
             console.rule()
             return Failure("Failed to establish a baseline for the original code - bevhavioral tests failed.")
-        if not coverage_critic(coverage_results, "pytest"):
+        if not coverage_critic(coverage_results):
             did_pass_all_tests = all(result.did_pass for result in behavioral_results)
             if not did_pass_all_tests:
                 return Failure("Tests failed to pass for the original code.")

codeflash/result/critic.py

@@ -2,7 +2,6 @@
 
 from typing import TYPE_CHECKING
 
-from codeflash.cli_cmds.console import logger
 from codeflash.code_utils import env_utils
 from codeflash.code_utils.config_consts import (
     COVERAGE_THRESHOLD,
@@ -109,11 +108,8 @@ def quantity_of_tests_critic(candidate_result: OptimizedCandidateResult | Origin
     return bool(pass_count >= 1 and report[models.TestType.REPLAY_TEST]["passed"] >= 1)  # type: ignore  # noqa: PGH003
 
 
-def coverage_critic(original_code_coverage: CoverageData | None, test_framework: str) -> bool:
+def coverage_critic(original_code_coverage: CoverageData | None) -> bool:
     """Check if the coverage meets the threshold."""
-    if test_framework == "unittest":
-        logger.debug("Coverage critic is not implemented for unittest yet.")
-        return True
     if original_code_coverage:
         return original_code_coverage.coverage >= COVERAGE_THRESHOLD
     return False

tests/test_critic.py

@@ -371,7 +371,7 @@ def test_coverage_critic() -> None:
         status=CoverageStatus.PARSED_SUCCESSFULLY,
     )
 
-    assert coverage_critic(passing_coverage, "pytest") is True
+    assert coverage_critic(passing_coverage) is True
 
     border_coverage = CoverageData(
         file_path=Path("test_file.py"),
@@ -392,7 +392,7 @@ def test_coverage_critic() -> None:
         status=CoverageStatus.PARSED_SUCCESSFULLY,
     )
 
-    assert coverage_critic(border_coverage, "pytest") is True
+    assert coverage_critic(border_coverage) is True
 
     failing_coverage = CoverageData(
         file_path=Path("test_file.py"),
@@ -413,29 +413,7 @@ def test_coverage_critic() -> None:
         status=CoverageStatus.PARSED_SUCCESSFULLY,
     )
 
-    assert coverage_critic(failing_coverage, "pytest") is False
-
-    unittest_coverage = CoverageData(
-        file_path=Path("test_file.py"),
-        coverage=0,
-        function_name="test_function",
-        functions_being_tested=["function1", "function2"],
-        graph={},
-        code_context=mock_code_context,
-        main_func_coverage=FunctionCoverage(
-            name="test_function",
-            coverage=0,
-            executed_lines=[10],
-            unexecuted_lines=[2],
-            executed_branches=[[5]],
-            unexecuted_branches=[[1]],
-        ),
-        dependent_func_coverage=None,
-        status=CoverageStatus.PARSED_SUCCESSFULLY,
-    )
-
-    assert coverage_critic(unittest_coverage, "unittest") is True
-
+    assert coverage_critic(failing_coverage) is False
 
 def test_throughput_gain() -> None:
     """Test throughput_gain calculation."""