fix: null as an array offset is deprecated, use an empty string instead (#9849)

* fix: null as an array offset is deprecated, use an empty string instead

Co-authored-by: Denny Septian Panggabean <97607754+ddevsr@users.noreply.github.com>

* update tests signature

---------

Co-authored-by: Denny Septian Panggabean <97607754+ddevsr@users.noreply.github.com>

Author: michalsn

system/Autoloader/FileLocatorCached.php

@@ -163,14 +163,16 @@ public function listNamespaceFiles(string $prefix, string $path): array
 
     public function locateFile(string $file, ?string $folder = null, string $ext = 'php'): false|string
     {
-        if (isset($this->cache['locateFile'][$file][$folder][$ext])) {
-            return $this->cache['locateFile'][$file][$folder][$ext];
+        $folderKey = $folder ?? '';
+
+        if (isset($this->cache['locateFile'][$file][$folderKey][$ext])) {
+            return $this->cache['locateFile'][$file][$folderKey][$ext];
         }
 
         $files = $this->locator->locateFile($file, $folder, $ext);
 
-        $this->cache['locateFile'][$file][$folder][$ext] = $files;
-        $this->cacheUpdated                              = true;
+        $this->cache['locateFile'][$file][$folderKey][$ext] = $files;
+        $this->cacheUpdated                                 = true;
 
         return $files;
     }

tests/system/Validation/RulesTest.php

@@ -669,7 +669,7 @@ public static function provideInList(): iterable
     }
 
     #[DataProvider('provideRequiredWith')]
-    public function testRequiredWith(?string $field, ?string $check, bool $expected): void
+    public function testRequiredWith(string $field, ?string $check, bool $expected): void
     {
         $data = [
             'foo'   => 'bar',
@@ -693,8 +693,8 @@ public static function provideRequiredWith(): iterable
             ['nope', 'bar', false],
             ['foo', 'bar', true],
             ['nope', 'baz', true],
-            [null, null, true],
-            [null, 'foo', false],
+            ['', null, true],
+            ['', 'foo', false],
             ['foo', null, true],
             [
                 'array.emptyField1',
@@ -779,7 +779,7 @@ public static function provideRequiredWithAndOtherRuleWithValueZero(): iterable
     }
 
     #[DataProvider('provideRequiredWithout')]
-    public function testRequiredWithout(?string $field, ?string $check, bool $expected): void
+    public function testRequiredWithout(string $field, ?string $check, bool $expected): void
     {
         $data = [
             'foo'   => 'bar',
@@ -802,8 +802,8 @@ public static function provideRequiredWithout(): iterable
         yield from [
             ['nope', 'bars', false],
             ['foo', 'nope', true],
-            [null, null, false],
-            [null, 'foo', true],
+            ['', null, false],
+            ['', 'foo', true],
             ['foo', null, true],
             [
                 'array.emptyField1',