refactor: rules test

ddevsr · ddevsr · commit 54903ef2d723 · 2025-12-20T06:45:39.000+07:00
diff --git a/tests/system/Validation/RulesTest.php b/tests/system/Validation/RulesTest.php
@@ -779,7 +779,7 @@ public static function provideRequiredWithAndOtherRuleWithValueZero(): iterable
     }
 
     #[DataProvider('provideRequiredWithout')]
-    public function testRequiredWithout(?string $field, ?string $check, bool $expected): void
+    public function testRequiredWithout(string $field, ?string $check, bool $expected): void
     {
         $data = [
             'foo'   => 'bar',
@@ -802,8 +802,8 @@ public static function provideRequiredWithout(): iterable
         yield from [
             ['nope', 'bars', false],
             ['foo', 'nope', true],
-            [null, null, false],
-            [null, 'foo', true],
+            ['', null, false],
+            ['', 'foo', true],
             ['foo', null, true],
             [
                 'array.emptyField1',

Original file line number	Diff line number	Diff line change
`@@ -779,7 +779,7 @@ public static function provideRequiredWithAndOtherRuleWithValueZero(): iterable`
`779`	`779`	`}`
`780`	`780`
`781`	`781`	`#[DataProvider('provideRequiredWithout')]`
`782`		`- public function testRequiredWithout(?string $field, ?string $check, bool $expected): void`
	`782`	`+ public function testRequiredWithout(string $field, ?string $check, bool $expected): void`
`783`	`783`	`{`
`784`	`784`	`$data = [`
`785`	`785`	`'foo' => 'bar',`
`@@ -802,8 +802,8 @@ public static function provideRequiredWithout(): iterable`
`802`	`802`	`yield from [`
`803`	`803`	`['nope', 'bars', false],`
`804`	`804`	`['foo', 'nope', true],`
`805`		`- [null, null, false],`
`806`		`- [null, 'foo', true],`
	`805`	`+ ['', null, false],`
	`806`	`+ ['', 'foo', true],`
`807`	`807`	`['foo', null, true],`
`808`	`808`	`[`
`809`	`809`	`'array.emptyField1',`