refactor: fix default value and change to not nullable

kenjis · kenjis · commit 0b43684a99fc · 2022-05-10T21:23:21.000+09:00
diff --git a/src/Helpers/email_helper.php b/src/Helpers/email_helper.php
@@ -8,7 +8,7 @@
      *
      * @internal
      */
-    function emailer(?array $overrides = null): Email
+    function emailer(array $overrides = []): Email
     {
         helper('setting');
 
@@ -35,7 +35,7 @@ function emailer(?array $overrides = null): Email
             'DSN'           => setting('Email.DSN'),
         ];
 
-        if (is_array($overrides) && count($overrides)) {
+        if (count($overrides)) {
             $config = array_merge($overrides, $config);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`* @internal`
`10`	`10`	`*/`
`11`		`- function emailer(?array $overrides = null): Email`
	`11`	`+ function emailer(array $overrides = []): Email`
`12`	`12`	`{`
`13`	`13`	`helper('setting');`
`14`	`14`
`@@ -35,7 +35,7 @@ function emailer(?array $overrides = null): Email`
`35`	`35`	`'DSN' => setting('Email.DSN'),`
`36`	`36`	`];`
`37`	`37`
`38`		`- if (is_array($overrides) && count($overrides)) {`
	`38`	`+ if (count($overrides)) {`
`39`	`39`	`$config = array_merge($overrides, $config);`
`40`	`40`	`}`
`41`	`41`