refactor: remove code for 4.2.x or before

Author: kenjis

src/Test/MockInputOutput.php

@@ -5,7 +5,6 @@
 namespace CodeIgniter\Shield\Test;
 
 use CodeIgniter\CLI\CLI;
-use CodeIgniter\CodeIgniter;
 use CodeIgniter\Shield\Commands\Utils\InputOutput;
 use CodeIgniter\Shield\Exceptions\LogicException;
 use CodeIgniter\Test\Filters\CITestStreamFilter;
@@ -52,23 +51,21 @@ public function prompt(string $field, $options = null, $validation = null): stri
     {
         $input = array_shift($this->inputs);
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::registration();
-            CITestStreamFilter::addOutputFilter();
+        CITestStreamFilter::registration();
+        CITestStreamFilter::addOutputFilter();
 
-            PhpStreamWrapper::register();
-            PhpStreamWrapper::setContent($input);
+        PhpStreamWrapper::register();
+        PhpStreamWrapper::setContent($input);
 
-            $userInput = CLI::prompt($field, $options, $validation);
+        $userInput = CLI::prompt($field, $options, $validation);
 
-            PhpStreamWrapper::restore();
+        PhpStreamWrapper::restore();
 
-            CITestStreamFilter::removeOutputFilter();
-            CITestStreamFilter::removeErrorFilter();
+        CITestStreamFilter::removeOutputFilter();
+        CITestStreamFilter::removeErrorFilter();
 
-            if ($input !== $userInput) {
-                throw new LogicException($input . '!==' . $userInput);
-            }
+        if ($input !== $userInput) {
+            throw new LogicException($input . '!==' . $userInput);
         }
 
         return $input;
@@ -79,23 +76,13 @@ public function write(
         ?string $foreground = null,
         ?string $background = null
     ): void {
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::registration();
-            CITestStreamFilter::addOutputFilter();
-        } else {
-            CITestStreamFilter::$buffer = '';
-
-            $streamFilter = stream_filter_append(STDOUT, 'CITestStreamFilter');
-        }
+        CITestStreamFilter::registration();
+        CITestStreamFilter::addOutputFilter();
 
         CLI::write($text, $foreground, $background);
         $this->outputs[] = CITestStreamFilter::$buffer;
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::removeOutputFilter();
-            CITestStreamFilter::removeErrorFilter();
-        } else {
-            stream_filter_remove($streamFilter);
-        }
+        CITestStreamFilter::removeOutputFilter();
+        CITestStreamFilter::removeErrorFilter();
     }
 }

tests/Commands/SetupTest.php

@@ -4,7 +4,6 @@
 
 namespace Tests\Commands;
 
-use CodeIgniter\CodeIgniter;
 use CodeIgniter\Shield\Commands\Setup;
 use CodeIgniter\Test\Filters\CITestStreamFilter;
 use Config\Services;
@@ -16,31 +15,20 @@
  */
 final class SetupTest extends TestCase
 {
-    private $streamFilter;
-
     protected function setUp(): void
     {
         parent::setUp();
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::registration();
-            CITestStreamFilter::addOutputFilter();
-        } else {
-            CITestStreamFilter::$buffer = '';
-            $this->streamFilter         = stream_filter_append(STDOUT, 'CITestStreamFilter');
-        }
+        CITestStreamFilter::registration();
+        CITestStreamFilter::addOutputFilter();
     }
 
     protected function tearDown(): void
     {
         parent::tearDown();
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::removeOutputFilter();
-            CITestStreamFilter::removeErrorFilter();
-        } else {
-            stream_filter_remove($this->streamFilter);
-        }
+        CITestStreamFilter::removeOutputFilter();
+        CITestStreamFilter::removeErrorFilter();
     }
 
     public function testRun(): void

tests/Commands/UserModelGeneratorTest.php

@@ -4,7 +4,6 @@
 
 namespace Tests\Commands;
 
-use CodeIgniter\CodeIgniter;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\Filters\CITestStreamFilter;
 
@@ -13,22 +12,13 @@
  */
 final class UserModelGeneratorTest extends CIUnitTestCase
 {
-    private $streamFilter;
-
     protected function setUp(): void
     {
         parent::setUp();
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::registration();
-            CITestStreamFilter::addOutputFilter();
-            CITestStreamFilter::addErrorFilter();
-        } else {
-            CITestStreamFilter::$buffer = '';
-
-            $this->streamFilter = stream_filter_append(STDOUT, 'CITestStreamFilter');
-            $this->streamFilter = stream_filter_append(STDERR, 'CITestStreamFilter');
-        }
+        CITestStreamFilter::registration();
+        CITestStreamFilter::addOutputFilter();
+        CITestStreamFilter::addErrorFilter();
 
         if (is_file(HOMEPATH . 'src/Models/UserModel.php')) {
             copy(HOMEPATH . 'src/Models/UserModel.php', HOMEPATH . 'src/Models/UserModel.php.bak');
@@ -41,12 +31,8 @@ protected function tearDown(): void
     {
         parent::tearDown();
 
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            CITestStreamFilter::removeOutputFilter();
-            CITestStreamFilter::removeErrorFilter();
-        } else {
-            stream_filter_remove($this->streamFilter);
-        }
+        CITestStreamFilter::removeOutputFilter();
+        CITestStreamFilter::removeErrorFilter();
 
         $this->deleteTestFiles();
 

tests/Controllers/LoginTest.php

@@ -4,7 +4,6 @@
 
 namespace Tests\Controllers;
 
-use CodeIgniter\CodeIgniter;
 use CodeIgniter\Config\Factories;
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Shield\Authentication\Actions\Email2FA;
@@ -110,11 +109,7 @@ public function testLoginTooLongPasswordArgon2id(): void
 
     public function testLoginActionEmailSuccess(): void
     {
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            Time::setTestNow('March 10, 2017', 'UTC');
-        } else {
-            Time::setTestNow('March 10, 2017', 'America/Chicago');
-        }
+        Time::setTestNow('March 10, 2017', 'UTC');
 
         $this->user->createEmailIdentity([
             'email'    => 'foo@example.com',
@@ -166,11 +161,7 @@ public function testAfterLoggedInNotDisplayLoginPage(): void
 
     public function testLoginActionUsernameSuccess(): void
     {
-        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
-            Time::setTestNow('March 10, 2017', 'UTC');
-        } else {
-            Time::setTestNow('March 10, 2017', 'America/Chicago');
-        }
+        Time::setTestNow('March 10, 2017', 'UTC');
 
         // Add 'username' to $validFields
         $authConfig                = config('Auth');