feat: add conditional auth actions#1328
Open
memleakd wants to merge 1 commit into
Open
Conversation
- add ConditionalActionInterface for opt-in per-user action checks - skip conditional login/register actions when they do not apply - keep stored activation identities enforced for inactive users - document conditional action behavior and activation edge cases - add login, registration, magic-link, and filter coverage Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a small opt-in way for auth actions to decide whether they apply to a specific user.
The idea came from the earlier MFA/2FA discussions and stalled work around Shield.
This is the first small piece: actions can implement
ConditionalActionInterfaceand returntrueorfalsefromappliesTo(User $user). That makes cases like "require an action only for admins" possible without changing existing actions or forcing every app into the same policy.Existing actions keep working as before. If an action does not implement the new interface, Shield treats it as always applicable.
A couple of edge cases are handled intentionally:
This should give Shield a safer foundation for future MFA work, while keeping this PR focused on the existing auth action system.
Tests cover login actions, registration activation, stored action identities, magic-link activation, and session filter behavior.
Checklist: