Skip to content

Commit 54bd637

Browse files
committed
Fix signing with empty vars
1 parent 3a8088a commit 54bd637

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,22 @@ jobs:
7171
run: bun run scripts/build-electron.ts
7272

7373
- name: Publish to GitHub Releases
74+
shell: bash
7475
env:
7576
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
76-
# macOS signing
7777
CSC_LINK: ${{ secrets.MACOS_CERTIFICATE }}
7878
CSC_KEY_PASSWORD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
79-
# macOS notarization
8079
APPLE_ID: ${{ secrets.APPLE_ID }}
8180
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
8281
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
83-
# Windows signing
8482
WIN_CSC_LINK: ${{ secrets.WIN_CERTIFICATE }}
8583
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CERTIFICATE_PWD }}
8684
run: |
85+
# Unset empty signing vars so electron-builder ignores them
86+
[ -z "$CSC_LINK" ] && unset CSC_LINK CSC_KEY_PASSWORD && export CSC_IDENTITY_AUTO_DISCOVERY=false
87+
[ -z "$APPLE_ID" ] && unset APPLE_ID APPLE_APP_SPECIFIC_PASSWORD APPLE_TEAM_ID
88+
[ -z "$WIN_CSC_LINK" ] && unset WIN_CSC_LINK WIN_CSC_KEY_PASSWORD
89+
8790
npx electron-builder --config electron-builder.json --${{ matrix.platform }} --publish always
8891
8992
# Upload artifacts for debugging

0 commit comments

Comments
 (0)