From 9aecbf3b00fe7575cd8e91883934381ae0738ffb Mon Sep 17 00:00:00 2001 From: Arjun Raja Yogidas Date: Mon, 17 Mar 2025 01:47:01 +0000 Subject: [PATCH] fix: Return empty network settings for non started containers Signed-off-by: Arjun Raja Yogidas --- pkg/inspecttypes/dockercompat/dockercompat.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkg/inspecttypes/dockercompat/dockercompat.go b/pkg/inspecttypes/dockercompat/dockercompat.go index 027726f14d8..27ae6dc44b6 100644 --- a/pkg/inspecttypes/dockercompat/dockercompat.go +++ b/pkg/inspecttypes/dockercompat/dockercompat.go @@ -458,6 +458,14 @@ func ContainerFromNative(n *native.Container) (*Container, error) { } c.NetworkSettings = nSettings c.HostConfig.PortBindings = *nSettings.Ports + } else { + // n.process is not set if the container is not started, making the networkSetting null + // we should send an empty object even in this case inorder for it to be compatible with docker inspect response + nSettings, err := networkSettingsFromNative(nil, n.Spec.(*specs.Spec)) + if err != nil { + return nil, err + } + c.NetworkSettings = nSettings } cpuSetting, err := cpuSettingsFromNative(n.Spec.(*specs.Spec))