#98 : test cases and bug fixes

Author: vikaskatiyar@live.com

src/commands/showfile.ts

@@ -9,7 +9,8 @@ export default class ShowFile extends Command {
 
   static flags = {
     help: flags.help({char: 'h'}),
-    file: flags.string({char: 'f' , description: 'formatted file to be shown'})
+    file: flags.string({char: 'f' , description: 'formatted file to be shown'}),
+    num: flags.string({char: 'n' , description: 'rows to show'})
   }
 
   static args = [{name: 'file'}]
@@ -19,6 +20,9 @@ export default class ShowFile extends Command {
     const {args, flags} = this.parse(ShowFile)
 
     args.file = this.getFilePath(flags, args)
+    args.num = this.getFileLinesToShow(flags)
+
+    // args.rowsToShow
 
     this.checkParameters(flags, args)
     this.showFile(args)
@@ -28,83 +32,71 @@ export default class ShowFile extends Command {
     if (args.file)
       return args.file
     if (flags.file)
-      return flags.file
+      return flags.file9
     Logger.error(this, 'File path not passed')
   }
 
+  private getFileLinesToShow(flags: any) {
+    return flags.num || 10
+  }
   // tslint:disable-next-line:no-unused
   private checkParameters(flags: unknown, args: { [p: string]: any }) {
     if (args.file === undefined || args.file === '')
       Logger.error(this, 'File path is empty')
     // others already checked
   }
 
-
   private showFile(args: any) {
-
     let data = Utilities.getStringFromFile(this, args.file)
-
     let rows = data.split('\n')
-
     let widthArray = []
 
-    let recordsToShow = 10
+    let recordsToShow = parseInt(args.num, 10) + 1
 
-    for(let i = 0; i < rows[0].length; i++){
-        widthArray[i] = 0
+    for (let i = 0; i < rows[0].length; i++) {
+      widthArray[i] = 0
     }
 
-    if(recordsToShow > rows.length){
-        recordsToShow = rows.length
+    if (recordsToShow > rows.length) {
+      recordsToShow = rows.length - 1
     }
 
-    for(let i = 0; i < recordsToShow; i++){
-        let row = rows[i].split(",");
-        let s = ''
-        for(let j = 0; j < row.length; j ++){
-            s = s + row[j]
-            if(widthArray[j] < row[j].length){
-                widthArray[j] = row[j].length
-            }
+    for (let i = 0; i < recordsToShow; i++) {
+      let row = rows[i].split(',')
+      for (let j = 0; j < row.length; j ++) {
+        if (widthArray[j] < row[j].length) {
+          widthArray[j] = row[j].length
         }
+      }
     }
 
-    this.printRow(rows[0].split(","), widthArray, "+", true)
-    for(let i = 0; i < recordsToShow-1; i++){
-        let row = rows[i]
-        this.printRow(row.split(','), widthArray, '|', false)
-        this.printRow(row.split(','), widthArray, '+', true)
+    this.printRow(rows[0].split(','), widthArray, '+', true)
+    for (let i = 0; i < recordsToShow; i++) {
+      let row = rows[i]
+      this.printRow(row.split(','), widthArray, '|', false)
+      this.printRow(row.split(','), widthArray, '+', true)
     }
-
+    this.log(`showing top ${recordsToShow} rows.`)
   }
 
-  private printRow(row: any, widthArray: any, seperator: any, isLineSeparator: any){
-      let output = seperator
-      for(let i = 0; i < row.length; i ++){
-          let totalSize = widthArray[i]
-
-          let dataLength = 0;
-          let space = "-"
-          if(!isLineSeparator){
-              let data = row[i]
-            data = data.split(/\r/)[0]
-              output += data
-              dataLength = data.length
-              space = ' '
-            //   this.log(`The output log upto here is : ${output}`)
-          }
-          
-          for(let j = 0; j < totalSize - dataLength; j++){
-              output += space
-          }
-          
-          output += seperator
-          if(!isLineSeparator){
-            // this.log(`The output log upto here is : ${output}`)
-            // Logger.info(this, output)
-          }
+  private printRow(row: any, widthArray: any, seperator: any, isLineSeparator: any) {
+    let output = seperator
+    for (let i = 0; i < row.length; i ++) {
+      let totalSize = widthArray[i]
+      let dataLength = 0
+      let space = '-'
+      if (!isLineSeparator) {
+        let data = row[i]
+        data = data.split(/\r/)[0]
+        output += data
+        dataLength = data.length
+        space = ' '
       }
-      this.log('' + output)
-      output = ''
+      for (let j = 0; j < totalSize - dataLength; j++) {
+        output += space
+      }
+      output += seperator
+    }
+    this.log('' + output)
   }
 }

test/commands/avro.test.ts

@@ -57,7 +57,7 @@ describe('avro', () => {
     .it('if get_schema outputs to console', ctx => {
       setTimeout(() =>
           expect(ctx.stdout).to.contain('success')
-        , 5000) //  wait for it to write stuff on console
+        , 9000) //  wait for it to write stuff on console
     })
 
   test

test/commands/showfile.test.ts

@@ -0,0 +1,44 @@
+import {expect, test} from '@oclif/test'
+
+describe('showfile', () => {
+  test
+    .stdout()
+    .command(['showfile'])
+    .exit(0)
+    .it('File path not passed', ctx => {
+      expect(ctx.stdout).to.contain('File path not passed')
+    })
+
+  test
+    .stdout()
+    .command(['showfile', 'test/resources/showfile.csv'])
+    .it('check 10 lines are found', ctx => {
+      expect(ctx.stdout).to.contain('|1       |2     |1  |14.0             |30.0708|1           |0         |')
+    })
+  test
+    .stdout()
+    .command(['showfile', 'test/resources/showfile.csv', '-n', '5'])
+    .it('check 5th line is found', ctx => {
+      expect(ctx.stdout).to.contain('|0       |3     |0  |35.0|8.05   |0           |0         |')
+    })
+
+  test
+    .stdout()
+    .command(['showfile', 'test/resources/showfile.csv', '-n', '900'])
+    .it('check if the given number is greater than total lines', ctx => {
+      expect(ctx.stdout).to.contain('|0       |3     |0  |32.0             |7.75    |0           |0         |')
+    })
+  test
+    .stdout()
+    .command(['showfile', 'test/resources/showfile.csv', '-n', '900'])
+    .it('check if 900 count is used, it shows only total present rows', ctx => {
+      expect(ctx.stdout).to.contain('showing top 892 rows.')
+    })
+  test
+    .stdout()
+    .command(['showfile', 'test/resources/showfile.csv', '-n', '0'])
+    .it('check if the given number is greater than total lines', ctx => {
+      expect(ctx.stdout).to.contain('|Survived|Pclass|Sex|Age|Fare|Family_count|Cabin_ind |')
+    })
+    //|Survived|Pclass|Sex|Age|Fare|Family_count|Cabin_ind |
+})