From cfa017b6959a79910fe6bcd2c41a8cec8ec5eeda Mon Sep 17 00:00:00 2001 From: Kubudak90 Date: Sat, 4 Apr 2026 22:54:32 +0300 Subject: [PATCH] fix: enable batching in mass-payout.js by deferring transfer.wait() The original implementation called await transfer.wait() inside the loop, which blocked each transfer from being batched. This fix: 1. Collects all transfers in an array first 2. Waits for all transfers to complete after queueing This enables proper batching and significantly improves performance when processing multiple payouts. Fixes #416 --- quickstart-template/mass-payout.js | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/quickstart-template/mass-payout.js b/quickstart-template/mass-payout.js index 7131b0ab..54e1510e 100644 --- a/quickstart-template/mass-payout.js +++ b/quickstart-template/mass-payout.js @@ -59,12 +59,14 @@ async function sendMassPayout(sendingWallet) { // Define amount to send. const transferAmount = 0.000002; const assetId = Coinbase.assets.Eth; + const transfers = []; try { const parser = fs .createReadStream("./wallet-array.csv") .pipe(parse({ delimiter: ",", from_line: 1 })); + // STEP 1: Queue all transfers (sequentially to enable batching) for await (const row of parser) { const address = row[0]; if (address) { @@ -76,14 +78,23 @@ async function sendMassPayout(sendingWallet) { destination: address, }); - await transfer.wait(); - - console.log(`Transfer to ${address} successful`); + transfers.push({ address, transfer }); + console.log(`Queued transfer to ${address}`); } catch (error) { - console.error(`Error transferring to ${address}: `, error); + console.error(`Error creating transfer to ${address}: `, error); } } } + + // STEP 2: Wait for all transfers to complete + for (const { address, transfer } of transfers) { + try { + await transfer.wait(); + console.log(`Transfer to ${address} successful`); + } catch (error) { + console.error(`Error waiting for transfer to ${address}: `, error); + } + } } catch (error) { console.error(`Error processing CSV file: `, error); }