feat(format): remove strict flag to enforce spec

Author: thekaveman

conventional_pre_commit/format.py

@@ -61,7 +61,7 @@ def conventional_types(types=[]):
     return types
 
 
-def is_conventional(input, types=DEFAULT_TYPES, optional_scope=True, is_strict=False):
+def is_conventional(input, types=DEFAULT_TYPES, optional_scope=True):
     """
     Returns True if input matches Conventional Commits formatting
     https://www.conventionalcommits.org
@@ -73,11 +73,11 @@ def is_conventional(input, types=DEFAULT_TYPES, optional_scope=True, is_strict=F
     regex = re.compile(pattern, re.MULTILINE)
 
     result = regex.match(input)
-    is_valid_subject = bool(result)
-    if is_valid_subject and is_strict and result.group("multi") and not result.group("sep"):
-        is_valid_subject = False
+    is_valid = bool(result)
+    if is_valid and result.group("multi") and not result.group("sep"):
+        is_valid = False
 
-    return is_valid_subject
+    return is_valid
 
 
 def has_autosquash_prefix(input):

conventional_pre_commit/hook.py

@@ -54,7 +54,7 @@ def main(argv=[]):
         if format.has_autosquash_prefix(message):
             return RESULT_SUCCESS
 
-    if format.is_conventional(message, args.types, args.optional_scope, args.strict):
+    if format.is_conventional(message, args.types, args.optional_scope):
         return RESULT_SUCCESS
     else:
         print(

tests/test_format.py

@@ -162,64 +162,40 @@ def test_is_conventional__with_scope():
     assert format.is_conventional(input)
 
 
-def test_is_conventional__body_multiline_not_strict():
-    input = """feat(scope): message
-
-    more message
-    """
-
-    assert format.is_conventional(input, is_strict=False)
-
-
-def test_is_conventional__body_multiline_no_body_not_strict():
-    input = """feat(scope): message
-
-    """
-    assert format.is_conventional(input, is_strict=False)
-
-
-def test_is_conventional__body_multiline_body_bad_type_strict():
+def test_is_conventional__body_multiline_body_bad_type():
     input = """wrong: message
 
     more_message
     """
 
-    assert not format.is_conventional(input, is_strict=True)
-
-
-def test_is_conventional__bad_body_multiline_not_strict():
-    input = """feat(scope): message
-    more message
-    """
-
-    assert format.is_conventional(input, is_strict=False)
+    assert not format.is_conventional(input)
 
 
-def test_is_conventional__bad_body_multiline_strict():
+def test_is_conventional__bad_body_multiline():
     input = """feat(scope): message
     more message
     """
 
-    assert not format.is_conventional(input, is_strict=True)
+    assert not format.is_conventional(input)
 
 
-def test_is_conventional__body_multiline_strict():
+def test_is_conventional__body_multiline():
     input = """feat(scope): message
 
     more message
     """
 
-    assert format.is_conventional(input, is_strict=True)
+    assert format.is_conventional(input)
 
 
-def test_is_conventional__bad_body_multiline_paragraphs_strict():
+def test_is_conventional__bad_body_multiline_paragraphs():
     input = """feat(scope): message
     more message
 
     more body message
     """
 
-    assert not format.is_conventional(input, is_strict=True)
+    assert not format.is_conventional(input)
 
 
 @pytest.mark.parametrize("char", ['"', "'", "`", "#", "&"])