cppcheck on Windows search the wrong cfg folder.

[seanyen]

Currently when you run cppcheck on conda-forge on Windows, it will search the cfg files under %CONDA_PREFIX%\Library\bin or %CONDA_PREFIX%\Library\bin\cfg. However, those files are under %CONDA_PREFIX%\Library\share\cppcheck\cfg. I am not yet sure how to instruct the Cppcheck to search a different path, and keep a record here.

[tovrstra]

Sorry for the long delay. I'm not a Windows user, so hard to tell what exactly the problem is. (P.S. I've added you as co-maintainer in #22.) Also on other OSs, the cfg files are installed in share/Cppcheck/cfg, where they do get found. This means the path is somehow not set correctly at compile time.

@timsnyder: do you have by any chance experience with Windows?

[pcasenove]

Hi,
Using cppcheck 2.6.1 package on Linux, I get the follwoing error:
$ cppcheck .
cppcheck: Failed to load library configuration file 'std.cfg'. File not found
nofile:0:0: information: Failed to load std.cfg. Your Cppcheck installation is broken, please re-install. The Cppcheck binary was compiled with FILESDIR set to "/home/conda/feedstock_root/build_artifacts/cppcheck_1633254921711/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/share/Cppcheck" and will therefore search for std.cfg in /home/conda/feedstock_root/build_artifacts/cppcheck_1633254921711/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/share/Cppcheck/cfg. [failedToLoadCfg]

Can we do something about it?

Thanks,

[tovrstra]

@pcasenove Thanks for reaching out! It should be possible to fix this. Would you know how? I don't have a windows machine at my disposal (and also lack experience with said OS).

[pcasenove]

I have this on Linux (Centos 7) and I don't have a windows machine at hand either to test. If you prefer, I can open another issue on this, for linux only.
I don't know what should be done, I think the .patch file is incorrect.

[tovrstra]

I'm sorry, I did not ready carefully. Fixing the patch would be great. I don't have much time at this stage to look into it.

[pcasenove]

OK... looking at the cppcheck code, it seems that the code to load std.cfg file has changed, explaining the crash: the patch is not applied I think...
https://github.com/danmar/cppcheck/blob/e13eba86e5e0d2fbc992d056de9581c0fdc8816f/cli/cppcheckexecutor.cpp

[pcasenove]

Using this make command in the build script seems to fix (for us):
VERBOSE=1 make install -j ${CPU_COUNT} CFGDIR=${PREFIX}/share/Cppcheck

[tovrstra]

Seems reasonable. To avoid similar problems in future, we should make a PR with changed tests, which result in this type of error, and then fix it.

[senecal-whoop]

I am currently seeing this issue on windows with cppcheck 2.6.2. Is there any resolution/fix here?

[tovrstra]

Can you try the suggestion by @pcasenove? Does this work for you?

I'm not a Windows user myself, so it would be good to have a contributor for this feedstock who can fix and test the recipe on Windows.

[timsnyder]

I took a serious look at this today and suspect that it has to do with limitations conda has in it's implementation of PREFIX substitution in binary files on windows (see https://github.com/conda/conda/blob/0fa068f7d54e685d66468d0eefe13379743dc125/conda/core/portability.py#L86-L92).

Looking at v1.7.2, it seems that CFGDIR is only used in the uninstall: target of the makefile. It may have helped in the past with related issues but I don't see how it would do anything in the current codebase.

I'll see if I can come up with something that will work on both Linux and Windows. I'm thinking of having something that will look with a path relative to where the executable is installed and lookup the executable path with something like https://github.com/gpakosz/whereami

[timsnyder]

The conan folks are also struggling with this behavior. I found conan-io/conan-center-index#10423 (comment) with some interesting pointers and discussions on the behavior of cppcheck.

[timsnyder]

They submitted a patch for mac in cppcheck-opensource/cppcheck#4071, and looking in between the two additions of their patch I see argv[0] twiddling for #ifdef _WIN32. and that code has been in cppcheck since the dawn of time (2014..) MartinDelille/cppcheck@f79e1b6

I was concerned about _WIN32 being only set for 32-bit systems but some looking around shows 64-bit windows platforms also have it set https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/64-bit-compiler?redirectedfrom=MSDN

[timsnyder]

I'm beginning to think that since we shouldn't be setting FILESDIR so that cppcheck will use paths relative to it's installed executable to find the cfg file. When I said "I'll see if I can come up with something that will work for Linux and Windows", that's what I was thinking and it looks like cppcheck already does it if you configure correctly during the build.

Now, I just need to figure out how to get cmake to not set FILESDIR and give it a try.