1.2.3 version Bugfix: README example broken #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
IgorChvyrov-sm
changed the title
v1r3n
reviewed
Nov 20, 2025
| cache_ttl_second: int = 0) -> Self: | ||
| self.task_reference_name = task_reference_name | ||
| self.task_type = task_type | ||
| self.task_name = task_name if task_name is not None else task_type.value |
Contributor
There was a problem hiding this comment.
isn't this needed for the workflow as code?
Contributor
Author
There was a problem hiding this comment.
task_name is not used anywhere, what do you mean by workflow as code ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug initially appeared in version 1.1.11 and was later fixed by 1.2.0 release. Since the version was restored back to 1.1.11 on top of which the 1.2.3 version was built the bug remained there
The issue link: #364