Skip to content

Commit b6eadd5

Browse files
authored
Merge pull request #1002 from nerilex/main
Add `--network=none` if `network_mode: none` is set
2 parents 0866492 + d95b4d0 commit b6eadd5

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix support for `network_mode: none`.

podman_compose.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -876,6 +876,7 @@ def get_net_args(compose, cnt):
876876
if net:
877877
if net == "none":
878878
is_bridge = False
879+
net_args.append("--network=none")
879880
elif net == "host":
880881
net_args.append(f"--network={net}")
881882
elif net.startswith("slirp4netns"): # Note: podman-specific network mode

tests/unit/test_get_net_args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def test_mixed_config(self):
257257
@parameterized.expand([
258258
("bridge", ["--network=bridge", f"--network-alias={SERVICE_NAME}"]),
259259
("host", ["--network=host"]),
260-
("none", []),
260+
("none", ["--network=none"]),
261261
("slirp4netns", ["--network=slirp4netns"]),
262262
("slirp4netns:cidr=10.42.0.0/24", ["--network=slirp4netns:cidr=10.42.0.0/24"]),
263263
("private", ["--network=private"]),

0 commit comments

Comments
 (0)