chore: update scripts to not use npm lifecycle commands [DX-589] (#2615)

* chore: update scripts to not use pre or post commands

* chore: update package lock

* chore: move check step to after build restore

* chore: update formatting

* chore: update installation of chrome for puppeteer

* chore: update puppeteer script

* chore: fix prettier

* chore: add no sandbox args for puppeteer

Author: chasepoirier

.github/workflows/check.yaml

@@ -80,6 +80,9 @@ jobs:
       - name: Run tests
         run: npm test
 
+      - name: Run demo tests
+        run: npm run test:demo-projects
+
   test-bundle-size:
     runs-on: ubuntu-latest
 
@@ -137,3 +140,6 @@ jobs:
 
       - name: Test TypeScript types
         run: npm run test:types
+
+      - name: Run checks
+        run: npm run check

.github/workflows/release.yaml

@@ -72,4 +72,11 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }}
           # required for browser output-integration tests
-          PUPPETEER_EXECUTABLE_PATH: /usr/bin/google-chrome
+          PUPPETEER_EXECUTABLE_PATH: /usr/bin/google-chrome
+      - name: Publish Docs
+        if: github.ref == 'refs/heads/master'
+        run: |
+          echo "Publishing Documentation"
+          npm run docs:publish
+        env:
+          GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }}

package-lock.json

@@ -53,7 +53,6 @@
     "build": "npm run clean && npm run build:esm && npm run build:bundles && rm -rf dist/esm-raw",
     "build:esm": "tsc",
     "build:bundles": "NODE_ENV=production rollup -c",
-    "postbuild": "npm run check && npm run test:demo-projects",
     "check": "npm run check:cjs && npm run check:esm && npm run check:browser && npm run check:browser-min",
     "check:browser": "es-check es2018 ./dist/contentful.browser.js",
     "check:browser-min": "es-check es2018 ./dist/contentful.browser.min.js",
@@ -73,12 +72,10 @@
     "test:integration:watch": "vitest ./test/integration",
     "test:size": "size-limit",
     "test:demo-projects": "npm run test:demo-node && npm run test:demo-browser",
-    "test:demo-node": "rimraf ./test/output-integration/node/node-modules && npm --prefix ./test/output-integration/node ci && vitest --run ./test/output-integration/node",
-    "test:demo-browser": "rimraf ./test/output-integration/browser/node-modules && npm --prefix ./test/output-integration/browser ci && npm --prefix ./test/output-integration/browser run test",
+    "test:demo-node": "rimraf ./test/output-integration/node/node-modules && npm --prefix ./test/output-integration/node ci && npm --prefix ./test/output-integration/node test",
+    "test:demo-browser": "rimraf ./test/output-integration/browser/node-modules && npm --prefix ./test/output-integration/browser ci && npm --prefix ./test/output-integration/browser run setup-test-env && npm --prefix ./test/output-integration/browser run test",
     "test:types": "tsd",
     "test:prepush": "npm run build && npm run test:unit && npm run test:types",
-    "prepublishOnly": "export PUBLISH_RUN=true && npm run build && unset PUBLISH_RUN",
-    "postpublish": "npm run docs:publish && npm run clean",
     "semantic-release": "semantic-release",
     "prepare": "husky",
     "precommit": "npm run lint && npm run prettier:check",
@@ -136,7 +133,7 @@
   "lint-staged": {
     "*.{js,jsx,ts,tsx}": [
       "prettier --write",
-      "eslint"
+      "eslint --fix"
     ],
     "*.md": [
       "prettier --write"

package.json

@@ -6,9 +6,10 @@
   "type": "module",
   "scripts": {
     "test": "vitest --run",
-    "preinstall": "npm run install:browser && npm run install:bundle",
     "install:bundle": "cp ../../../dist/contentful.browser.min.js ./public/.",
-    "install:browser": "npx puppeteer browser install"
+    "install:browser": "npx puppeteer browser install",
+    "setup-puppeteer": "node ./node_modules/puppeteer/install.mjs",
+    "setup-test-env": "npm run setup-puppeteer && npm run install:browser && npm run install:bundle"
   },
   "author": "",
   "license": "ISC",

test/output-integration/browser/package.json

@@ -8,7 +8,8 @@ let page: Page
 
 beforeAll(async () => {
   browser = await puppeteer.launch({
-    headless: 'new',
+    headless: true,
+    args: ['--no-sandbox', '--disable-setuid-sandbox'],
   })
 })
 

test/output-integration/browser/vitest.setup.ts

@@ -3,8 +3,9 @@
   "version": "1.0.0",
   "description": "",
   "main": "index.js",
+  "type": "module",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "vitest --run"
   },
   "author": "",
   "license": "ISC",

test/output-integration/node/package.json

@@ -0,0 +1,10 @@
+import { defineConfig } from 'vitest/config'
+
+export default defineConfig({
+  test: {
+    globals: true,
+    dir: '.',
+    environment: 'node',
+    testTimeout: 10000,
+  },
+})