Code Updated as per SonarQube Report Suggestions

Author: KHardik1698

src/commands/cm/stacks/validate-regex.ts

@@ -4,7 +4,7 @@ import {inquireAlias, inquireModule} from '../../../utils/interactive'
 import connectStack from '../../../utils/connect-stack'
 const regexMessages = require('../../../../messages/index.json').validateRegex
 
-export default class CmStacksValidateRegex extends Command {
+export default class ValidateRegex extends Command {
   static description = regexMessages.command.description
 
   static flags = {
@@ -26,7 +26,7 @@ export default class CmStacksValidateRegex extends Command {
   ]
 
   async run() {
-    const {flags} = this.parse(CmStacksValidateRegex)
+    const commandObject = this.parse(ValidateRegex)
 
     let authToken
     try {
@@ -37,21 +37,21 @@ export default class CmStacksValidateRegex extends Command {
       })
     }
 
-    await inquireAlias(flags)
+    await inquireAlias(commandObject.flags)
 
     let tokenDetails: any
     try {
-      tokenDetails = await this.getToken(flags.alias)
+      tokenDetails = await this.getToken(commandObject.flags.alias)
     } catch (error) {
       this.error(regexMessages.errors.tokenNotFound, {
         ref: regexMessages.command.addManagementToken,
       })
     }
 
-    await inquireModule(flags)
+    await inquireModule(commandObject.flags)
 
     try {
-      await connectStack(flags, authToken, tokenDetails.apiKey)
+      await connectStack(commandObject.flags, authToken, tokenDetails.apiKey)
     } catch (error) {
       this.error(regexMessages.errors.stack.fetch)
     }

src/utils/output.ts src/utils/generate-output.tssrc/utils/output.ts renamed to src/utils/generate-output.ts

@@ -1,6 +1,6 @@
 import {cli} from 'cli-ux'
-import safeRegexCheck from './safe-regex'
-import generateOutput from './output'
+import safeRegex from './safe-regex'
+import generateOutput from './generate-output'
 const regexMessages = require('../../messages/index.json').validateRegex
 
 export default async function processStack(flags: any, stack: any, startTime: number) {
@@ -12,19 +12,19 @@ export default async function processStack(flags: any, stack: any, startTime: nu
   const tableData: object[] = []
   if (flags.contentType) {
     const contentTypes = stack.contentType().query(query).find()
-    await contentTypes.then((contentTypes: any) => {
-      contentTypes.items.forEach((contentType: any) => {
-        safeRegexCheck(contentType, invalidRegex, tableData, 'Content Type')
+    await contentTypes.then((contentTypesObject: any) => {
+      contentTypesObject.items.forEach((contentType: any) => {
+        safeRegex(contentType, invalidRegex, tableData, 'Content Type')
       })
     }).catch(() => {
       throw new Error(regexMessages.errors.stack.contentTypes)
     })
   }
   if (flags.globalField) {
     const globalFields = stack.globalField().query(query).find()
-    await globalFields.then((globalFields: any) => {
-      globalFields.items.forEach((globalField: any) => {
-        safeRegexCheck(globalField, invalidRegex, tableData, 'Global Field')
+    await globalFields.then((globalFieldsObject: any) => {
+      globalFieldsObject.items.forEach((globalField: any) => {
+        safeRegex(globalField, invalidRegex, tableData, 'Global Field')
       })
     }).catch(() => {
       throw new Error(regexMessages.errors.stack.globalFields)

src/utils/process-stack.ts

@@ -1,11 +1,11 @@
 const safe = require('safe-regex')
 
-const safeRegexCheck = (document: any, invalidRegex: any, tableData: any, type: string) => {
+const safeRegex = (document: any, invalidRegex: any, tableData: any, type: string) => {
   const beforeCount = invalidRegex.length
   function checkSchemaFieldRegex(schema: any, currentPath: string, nested: boolean) {
     let newPath = ''
-    function path(currentPath: string, uid: string) {
-      return currentPath.trim() === '' ? uid : [currentPath, uid].join('.')
+    function path(currentFieldPath: string, uid: string) {
+      return currentFieldPath.trim() === '' ? uid : [currentFieldPath, uid].join('.')
     }
     schema.forEach((field: any) => {
       newPath = path(currentPath, field.uid)
@@ -52,4 +52,4 @@ const safeRegexCheck = (document: any, invalidRegex: any, tableData: any, type:
   checkSchemaFieldRegex(document.schema, '', false)
 }
 
-export default safeRegexCheck
+export default safeRegex

src/utils/safe-regex.ts

@@ -5,7 +5,7 @@ import processStack from '../../src/utils/process-stack'
 const regexMessages = require('../../messages/index.json').validateRegex
 
 jest.mock('@contentstack/management', () => ({client: jest.fn()}))
-jest.mock('../../src/utils/output.ts')
+jest.mock('../../src/utils/generate-output.ts')
 jest.mock('../../src/utils/process-stack.ts')
 
 /* @ts-ignore */

test/utils/connect-stack.test.ts

@@ -1,6 +1,6 @@
 import * as path from 'path'
 import * as fs from 'fs'
-import generateOutput from '../../src/utils/output'
+import generateOutput from '../../src/utils/generate-output'
 const invalidJsonOutput = require('../data/invalidRegex.json')
 const invalidTableOutput = require('../data/tableData.json')
 const regexMessages = require('../../messages/index.json').validateRegex

test/utils/output.test.ts test/utils/generate-output.test.tstest/utils/output.test.ts renamed to test/utils/generate-output.test.ts

@@ -1,10 +1,10 @@
 import {cli} from 'cli-ux'
 import processStack from '../../src/utils/process-stack'
-import generateOutput from '../../src/utils/output'
+import generateOutput from '../../src/utils/generate-output'
 const validDocument = require('../data/validDocument.json')
 const regexMessages = require('../../messages/index.json').validateRegex
 
-jest.mock('../../src/utils/output.ts')
+jest.mock('../../src/utils/generate-output.ts')
 
 /* @ts-ignore */
 cli = ({

test/utils/process-stack.test.ts

@@ -1,4 +1,4 @@
-import safeRegexCheck from '../../src/utils/safe-regex'
+import safeRegex from '../../src/utils/safe-regex'
 const validDocument = require('../data/validDocument.json')
 const invalidDocument = require('../data/invalidDocument.json')
 const invalidJsonOutput = require('../data/invalidRegex.json')
@@ -16,7 +16,7 @@ describe('Safe Regex Check in Schema', () => {
       const invalidRegex: object[] = []
       const tableData: object[] = []
       const moduleType = 'Content Type'
-      safeRegexCheck(validDocument, invalidRegex, tableData, moduleType)
+      safeRegex(validDocument, invalidRegex, tableData, moduleType)
       expect(invalidRegex).toStrictEqual([])
       expect(tableData).toStrictEqual([])
     })
@@ -25,7 +25,7 @@ describe('Safe Regex Check in Schema', () => {
       const invalidRegex: object[] = []
       const tableData: object[] = []
       const moduleType = 'Content Type'
-      safeRegexCheck(invalidDocument, invalidRegex, tableData, moduleType)
+      safeRegex(invalidDocument, invalidRegex, tableData, moduleType)
       expect(invalidRegex).toStrictEqual(invalidJsonOutput)
       expect(tableData).toStrictEqual(invalidTableOutput)
     })
@@ -36,7 +36,7 @@ describe('Safe Regex Check in Schema', () => {
       const invalidRegex: object[] = []
       const tableData: object[] = []
       const moduleType = 'Global Field'
-      safeRegexCheck(validDocument, invalidRegex, tableData, moduleType)
+      safeRegex(validDocument, invalidRegex, tableData, moduleType)
       expect(invalidRegex).toStrictEqual([])
       expect(tableData).toStrictEqual([])
     })
@@ -45,7 +45,7 @@ describe('Safe Regex Check in Schema', () => {
       const invalidRegex: object[] = []
       const tableData: object[] = []
       const moduleType = 'Global Field'
-      safeRegexCheck(invalidDocument, invalidRegex, tableData, moduleType)
+      safeRegex(invalidDocument, invalidRegex, tableData, moduleType)
       expect(invalidRegex).toStrictEqual(invalidJsonOutputGf)
       expect(tableData).toStrictEqual(invalidTableOutputGf)
     })