fix: otplib method migration and test cases

Author: nadeem-cs

.talismanrc

@@ -1,4 +1,8 @@
 fileignoreconfig:
+  - filename: test/unit/ContentstackClient-test.js
+    checksum: ffeb69822e7614a9ab14bb26f5f3ec8bdbbb6d3feb259064bda6c1379e3c7d37
+  - filename: lib/contentstackClient.js
+    checksum: f564f6eee5c17dc73abdeab4be226a3b37942893e149d907d2a4ef415c485c5e
   - filename: test/unit/globalField-test.js
     checksum: 25185e3400a12e10a043dc47502d8f30b7e1c4f2b6b4d3b8b55cdc19850c48bf
   - filename: lib/stack/index.js
@@ -26,10 +30,6 @@ fileignoreconfig:
     checksum: e8a32ffbbbdba2a15f3d327273f0a5b4eb33cf84cd346562596ab697125bbbc6
   - filename: test/sanity-check/api/bulkOperation-test.js
     checksum: f40a14c84ab9a194aaf830ca68e14afde2ef83496a07d4a6393d7e0bed15fb0e
-  - filename: lib/contentstackClient.js
-    checksum: b76ca091caa3a1b2658cd422a2d8ef3ac9996aea0aff3f982d56bb309a3d9fde
-  - filename: test/unit/ContentstackClient-test.js
-    checksum: 974a4f335aef025b657d139bb290233a69bed1976b947c3c674e97baffe4ce2f
   - filename: test/unit/ContentstackHTTPClient-test.js
     checksum: 4043efd843e24da9afd0272c55ef4b0432e3374b2ca12b913f1a6654df3f62be
   - filename: test/unit/contentstack-test.js

lib/contentstackClient.js

@@ -7,7 +7,7 @@ import cloneDeep from 'lodash/cloneDeep'
 import { User } from './user/index'
 import error from './core/contentstackError'
 import OAuthHandler from './core/oauthHandler'
-import { authenticator } from 'otplib'
+import { generateSync } from 'otplib'
 
 export default function contentstackClient ({ http }) {
   /**
@@ -43,7 +43,7 @@ export default function contentstackClient ({ http }) {
     requestBody = credentials
 
     if (!requestBody.tfa_token && mfaSecret) {
-      requestBody.tfa_token = authenticator.generate(mfaSecret)
+      requestBody.tfa_token = generateSync({ secret: mfaSecret })
     }
     return http.post('/user-session', { user: requestBody }, { params: params })
       .then((response) => {

test/unit/ContentstackClient-test.js

@@ -239,7 +239,7 @@ describe('Contentstack Client', () => {
     })
 
     it('should handle login with TOTP secret', done => {
-      const mfaSecret = 'MFASECRET'
+      const mfaSecret = 'JBSWY3DPEHPK3PXPJBSWY3DPEHPK3PXP'
 
       mock.onPost('/user-session').reply(config => {
         const data = JSON.parse(config.data)
@@ -416,7 +416,7 @@ describe('Contentstack Client', () => {
         .login({
           email: 'test@example.com',
           password: 'password123',
-          mfaSecret: 'MFASECRET'
+          mfaSecret: 'JBSWY3DPEHPK3PXPJBSWY3DPEHPK3PXP'
         })
         .then(response => {
           expect(response.user.authtoken).to.equal('Test Auth')

test/unit/taxonomy-test.js

@@ -101,7 +101,7 @@ describe('Contentstack Taxonomy test', () => {
   it('Taxonomy fetch with locale parameter test', done => {
     const mock = new MockAdapter(Axios)
     const queryParams = { locale: 'hi-in' }
-    mock.onGet('/taxonomies/UID', queryParams).reply(200, {
+    mock.onGet('/taxonomies/UID', { params: queryParams }).reply(200, {
       taxonomy: {
         ...taxonomyMock,
         locale: 'hi-in'
@@ -139,7 +139,7 @@ describe('Contentstack Taxonomy test', () => {
         referenced_content_type_count: 2
       }
     }
-    mock.onGet('/taxonomies/UID', queryParams).reply(200, responseData)
+    mock.onGet('/taxonomies/UID', { params: queryParams }).reply(200, responseData)
     makeTaxonomy({
       taxonomy: {
         ...systemUidMock
@@ -166,7 +166,7 @@ describe('Contentstack Taxonomy test', () => {
       include_fallback: true,
       fallback_locale: 'en-us'
     }
-    mock.onGet('/taxonomies/UID', queryParams).reply(200, {
+    mock.onGet('/taxonomies/UID', { params: queryParams }).reply(200, {
       taxonomy: {
         ...taxonomyMock,
         locale: 'hi-in'
@@ -199,7 +199,7 @@ describe('Contentstack Taxonomy test', () => {
         uuid: '65c091865ae75f256a76adc2'
       }
     }
-    mock.onGet('/taxonomies/UID', queryParams).reply(200, responseData)
+    mock.onGet('/taxonomies/UID', { params: queryParams }).reply(200, responseData)
     makeTaxonomy({
       taxonomy: {
         ...systemUidMock
@@ -234,7 +234,7 @@ describe('Contentstack Taxonomy test', () => {
   it('Taxonomies query with locale parameter test', done => {
     const mock = new MockAdapter(Axios)
     const queryParams = { locale: 'hi-in' }
-    mock.onGet('/taxonomies', queryParams).reply(200, {
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, {
       taxonomies: [
         {
           ...taxonomyMock,
@@ -275,7 +275,7 @@ describe('Contentstack Taxonomy test', () => {
       ],
       count: 1
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, responseData)
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, responseData)
     makeTaxonomy()
       .query(queryParams)
       .find()
@@ -299,7 +299,7 @@ describe('Contentstack Taxonomy test', () => {
       include_fallback: true,
       fallback_locale: 'en-us'
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, {
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, {
       taxonomies: [
         {
           ...taxonomyMock,
@@ -325,7 +325,7 @@ describe('Contentstack Taxonomy test', () => {
       asc: 'name',
       desc: 'created_at'
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, {
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, {
       taxonomies: [
         taxonomyMock
       ],
@@ -348,7 +348,7 @@ describe('Contentstack Taxonomy test', () => {
       typeahead: 'taxonomy',
       deleted: false
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, {
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, {
       taxonomies: [
         taxonomyMock
       ],
@@ -370,7 +370,7 @@ describe('Contentstack Taxonomy test', () => {
       skip: 10,
       limit: 5
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, {
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, {
       taxonomies: [
         taxonomyMock
       ],
@@ -400,7 +400,7 @@ describe('Contentstack Taxonomy test', () => {
       ],
       count: 1
     }
-    mock.onGet('/taxonomies', queryParams).reply(200, responseData)
+    mock.onGet('/taxonomies', { params: queryParams }).reply(200, responseData)
     makeTaxonomy()
       .query(queryParams)
       .find()
@@ -527,7 +527,7 @@ describe('Contentstack Taxonomy test', () => {
       notice: 'Taxonomy unlocalized successfully',
       status: 200
     }
-    mock.onDelete('/taxonomies/UID', { locale: 'hi-in' }).reply(200, deleteResponse)
+    mock.onDelete('/taxonomies/UID', { params: { locale: 'hi-in' } }).reply(200, deleteResponse)
     makeTaxonomy({
       taxonomy: {
         ...systemUidMock
@@ -571,7 +571,7 @@ describe('Contentstack Taxonomy test', () => {
       notice: 'Taxonomy unlocalized successfully',
       status: 200
     }
-    mock.onDelete('/taxonomies/UID', { locale: 'mr-in' }).reply(200, deleteResponse)
+    mock.onDelete('/taxonomies/UID', { params: { locale: 'mr-in' } }).reply(200, deleteResponse)
     makeTaxonomy({
       taxonomy: {
         ...systemUidMock