test: added additional test cases for nested attrs

Author: Jayesh2812

src/fromRedactor.tsx

@@ -797,7 +797,7 @@ const getFinalImageAttributes = ({elementAttrs, newChildren, extraAttrs, sizeAtt
   return imageAttrs
 }
 
-const getNestedValueIfAvailable = (value: string) => {
+export const getNestedValueIfAvailable = (value: string) => {
   try {
     if (typeof value === "string" && value.trim().match(/^{|\[/i)) {
       return JSON.parse(value);

test/fromRedactor.test.ts

@@ -1,5 +1,5 @@
 // @ts-nocheck
-import { fromRedactor } from "../src/fromRedactor"
+import { fromRedactor, getNestedValueIfAvailable } from "../src/fromRedactor"
 import { JSDOM } from "jsdom"
 import { isEqual } from "lodash"
 import omitdeep from "omit-deep-lodash"
@@ -227,6 +227,8 @@ describe("Testing html to json conversion", () => {
         expect(testResult).toBe(true)
     })
 
+    describe("Nested attrs", () =>{
+
     test("should convert stringified attrs to proper nested JSON attrs", () => {
       for (const testCase of expectedValue["nested-attrs"]) {
         const { json, html } = testCase;
@@ -236,4 +238,35 @@ describe("Testing html to json conversion", () => {
         expect(jsonValue).toStrictEqual(json);
       }
     });
-})
+
+    test("should not convert stringify attrs when `allowNonStandardTags` is not true", () => {
+        const html = `<p><span from="Paul, Addy" to="[object Object]">Hi There!</span></p>`;
+        const json = {"attrs": {}, "children": [{"attrs": {}, "children": [{"attrs": {"redactor-attributes": {"from": "Paul, Addy", "to": "[object Object]"}, "style": {}}, "children": [{"attrs": {"style": {}}, "text": "Hi There!"}], "type": "span", "uid": "uid"}], "type": "p", "uid": "uid"}], "type": "doc", "uid": "uid"};
+  
+        const dom = new JSDOM(html);
+        let htmlDoc = dom.window.document.querySelector("body");
+        const jsonValue = fromRedactor(htmlDoc);
+        expect(jsonValue).toStrictEqual(json);
+      });
+    })
+
+})
+
+
+describe('getNestedValueIfAvailable', () => {
+
+    it('should return the input value when it\'s not a string containing JSON', () => {
+      expect(getNestedValueIfAvailable(10)).toBe(10);
+      expect(getNestedValueIfAvailable(null)).toBeNull();
+      expect(getNestedValueIfAvailable('{ "name": "John", "age": }')).toBe('{ "name": "John", "age": }');
+      expect(getNestedValueIfAvailable({ "name": "John", "age": 30})).toStrictEqual({ "name": "John", "age": 30});
+      expect(getNestedValueIfAvailable('[Object Object]')).toBe('[Object Object]');
+    });
+
+    it('should return the parsed JSON when the input value is a string containing JSON', () => {
+      const value = '{ "name": "John", "age": 30 }';
+      const result = getNestedValueIfAvailable(value);
+      expect(result).toEqual({ name: "John", age: 30 });
+    });
+
+});

test/toRedactor.test.ts

@@ -122,11 +122,23 @@ describe("Testing json to html conversion", () => {
         let testResult = isEqual(htmlValue, expectedValue["inline-classname-and-id"].html)
         expect(testResult).toBe(true)
     })
-    test("should have stringified attrs for nested json", () => {
-        for (const testCase of expectedValue["nested-attrs"]) {
-          const { json, html } = testCase;
-          const htmlValue = toRedactor(json, { allowNonStandardTypes: true });
+
+    describe("Nested attrs", () => {
+
+        test("should have stringified attrs for nested json", () => {
+            for (const testCase of expectedValue["nested-attrs"]) {
+                const { json, html } = testCase;
+                const htmlValue = toRedactor(json, { allowNonStandardTypes: true });
+                expect(htmlValue).toBe(html);
+            }
+        });
+
+        test("should not convert to stringify attrs when `allowNonStandardTypes` is not true", () => {
+          const html = `This is HTML-formatted content.`
+          const json = {"type":"doc","attrs":{}, "children":[{"type":"aprimo","attrs":{ nestedAttrs: { "k1" : "v1"} },"children":[{"text":"This is HTML-formatted content."}]}]};
+
+          const htmlValue = toRedactor(json);
           expect(htmlValue).toBe(html);
-        }
-      });
+        });
+    })
 })