Add unit tests for httpgrpcutil package (#7352)

Author: archy-rock3t-cloud

pkg/util/httpgrpcutil/carrier_test.go

@@ -0,0 +1,67 @@
+package httpgrpcutil
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"github.com/weaveworks/common/httpgrpc"
+)
+
+func TestHttpgrpcHeadersCarrier_Set(t *testing.T) {
+	carrier := &HttpgrpcHeadersCarrier{}
+
+	carrier.Set("X-Trace-ID", "abc123")
+	carrier.Set("X-Span-ID", "def456")
+
+	require.Len(t, carrier.Headers, 2)
+	assert.Equal(t, "X-Trace-ID", carrier.Headers[0].Key)
+	assert.Equal(t, []string{"abc123"}, carrier.Headers[0].Values)
+	assert.Equal(t, "X-Span-ID", carrier.Headers[1].Key)
+	assert.Equal(t, []string{"def456"}, carrier.Headers[1].Values)
+}
+
+func TestHttpgrpcHeadersCarrier_ForeachKey(t *testing.T) {
+	carrier := &HttpgrpcHeadersCarrier{
+		Headers: []*httpgrpc.Header{
+			{Key: "key1", Values: []string{"val1a", "val1b"}},
+			{Key: "key2", Values: []string{"val2"}},
+		},
+	}
+
+	var collected []string
+	err := carrier.ForeachKey(func(key, val string) error {
+		collected = append(collected, key+"="+val)
+		return nil
+	})
+
+	require.NoError(t, err)
+	assert.Equal(t, []string{"key1=val1a", "key1=val1b", "key2=val2"}, collected)
+}
+
+func TestHttpgrpcHeadersCarrier_ForeachKey_returnsHandlerError(t *testing.T) {
+	carrier := &HttpgrpcHeadersCarrier{
+		Headers: []*httpgrpc.Header{
+			{Key: "key1", Values: []string{"val1"}},
+		},
+	}
+
+	handlerErr := errors.New("handler failed")
+	err := carrier.ForeachKey(func(key, val string) error {
+		return handlerErr
+	})
+
+	assert.Equal(t, handlerErr, err)
+}
+
+func TestHttpgrpcHeadersCarrier_ForeachKey_emptyHeaders(t *testing.T) {
+	carrier := &HttpgrpcHeadersCarrier{}
+
+	err := carrier.ForeachKey(func(key, val string) error {
+		t.Fatal("handler should not be called for empty headers")
+		return nil
+	})
+
+	assert.NoError(t, err)
+}

pkg/util/httpgrpcutil/header_test.go

@@ -0,0 +1,89 @@
+package httpgrpcutil
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/weaveworks/common/httpgrpc"
+)
+
+func TestGetHeader(t *testing.T) {
+	tests := []struct {
+		name     string
+		headers  []*httpgrpc.Header
+		key      string
+		expected string
+	}{
+		{
+			name:     "returns empty string for missing key",
+			headers:  nil,
+			key:      "X-Missing",
+			expected: "",
+		},
+		{
+			name: "returns first value for existing key",
+			headers: []*httpgrpc.Header{
+				{Key: "Content-Type", Values: []string{"application/json", "text/plain"}},
+			},
+			key:      "Content-Type",
+			expected: "application/json",
+		},
+		{
+			name: "does not match different key",
+			headers: []*httpgrpc.Header{
+				{Key: "Accept", Values: []string{"text/html"}},
+			},
+			key:      "Content-Type",
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			req := httpgrpc.HTTPRequest{Headers: tt.headers}
+			result := GetHeader(req, tt.key)
+			assert.Equal(t, tt.expected, result)
+		})
+	}
+}
+
+func TestGetHeaderValues(t *testing.T) {
+	tests := []struct {
+		name     string
+		headers  []*httpgrpc.Header
+		key      string
+		expected []string
+	}{
+		{
+			name:     "returns empty slice for missing key",
+			headers:  nil,
+			key:      "X-Missing",
+			expected: []string{},
+		},
+		{
+			name: "returns all values for existing key",
+			headers: []*httpgrpc.Header{
+				{Key: "Accept", Values: []string{"text/html", "application/json"}},
+			},
+			key:      "Accept",
+			expected: []string{"text/html", "application/json"},
+		},
+		{
+			name: "returns values from first matching header only",
+			headers: []*httpgrpc.Header{
+				{Key: "X-Custom", Values: []string{"first"}},
+				{Key: "X-Custom", Values: []string{"second"}},
+			},
+			key:      "X-Custom",
+			expected: []string{"first"},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			req := httpgrpc.HTTPRequest{Headers: tt.headers}
+			result := GetHeaderValues(req, tt.key)
+			assert.Equal(t, tt.expected, result)
+		})
+	}
+}