From 37a5bd589dad5ba45905395f5156cf9ad20ede22 Mon Sep 17 00:00:00 2001 From: Wendy Sun Date: Wed, 25 Feb 2026 22:09:00 +0800 Subject: [PATCH 1/2] chore: rename image src props to source --- src/markdown-processor/markdown-processor.test.js | 6 +++--- .../marked-extentions/image-display-link.js | 6 +++--- .../marked-extentions/image-display.js | 6 +++--- .../marked-extentions/image-link.js | 6 +++--- src/markdown-processor/marked-extentions/image.js | 6 +++--- .../image-display-link/ImageDisplayLink.jsx | 6 +++--- .../default-components/image-display/ImageDisplay.jsx | 11 ++++++++--- .../react/default-components/image-link/ImageLink.jsx | 6 +++--- .../react/default-components/image/Image.jsx | 6 +++--- 9 files changed, 32 insertions(+), 27 deletions(-) diff --git a/src/markdown-processor/markdown-processor.test.js b/src/markdown-processor/markdown-processor.test.js index 2cef15c..05064d9 100644 --- a/src/markdown-processor/markdown-processor.test.js +++ b/src/markdown-processor/markdown-processor.test.js @@ -309,7 +309,7 @@ describe('markdownProcessor', () => { alt: 'alt text', imageId: 'image-123', position: { start: 0, end: 52 }, - src: 'https://example.com/image.jpg', + source: 'https://example.com/image.jpg', target: 'https://example.com/target', }); }); @@ -346,7 +346,7 @@ describe('markdownProcessor', () => { display: 'Display caption', imageId: 'image-456', position: { start: 0, end: 41 }, - src: 'https://example.com/image2.jpg', + source: 'https://example.com/image2.jpg', }); }); @@ -382,7 +382,7 @@ describe('markdownProcessor', () => { display: 'Display caption', imageId: 'image-789', position: { start: 0, end: 72 }, - src: 'https://example.com/image3.jpg', + source: 'https://example.com/image3.jpg', target: 'https://example.com/details', }); }); diff --git a/src/markdown-processor/marked-extentions/image-display-link.js b/src/markdown-processor/marked-extentions/image-display-link.js index a5b5ddd..17e3a37 100644 --- a/src/markdown-processor/marked-extentions/image-display-link.js +++ b/src/markdown-processor/marked-extentions/image-display-link.js @@ -66,7 +66,7 @@ const markedImageDisplayLink = ({ imageFiles, shouldBuildImageObjectURL }) => { try { const imageFile = imageFiles[imageId]; - const src = shouldBuildImageObjectURL + const source = shouldBuildImageObjectURL ? blobUrlManager(imageId, imageFile) : imageFile; @@ -81,7 +81,7 @@ const markedImageDisplayLink = ({ imageFiles, shouldBuildImageObjectURL }) => { alt, display, imageId, - src, + source, target, }, }; @@ -99,7 +99,7 @@ const markedImageDisplayLink = ({ imageFiles, shouldBuildImageObjectURL }) => { alt, display, imageId, - src: imageId, + source: imageId, target, }, }; diff --git a/src/markdown-processor/marked-extentions/image-display.js b/src/markdown-processor/marked-extentions/image-display.js index 599a2c8..fc8ced2 100644 --- a/src/markdown-processor/marked-extentions/image-display.js +++ b/src/markdown-processor/marked-extentions/image-display.js @@ -60,7 +60,7 @@ const markedImageDisplay = ({ imageFiles, shouldBuildImageObjectURL }) => { try { const imageFile = imageFiles[imageId]; - const src = shouldBuildImageObjectURL + const source = shouldBuildImageObjectURL ? blobUrlManager(imageId, imageFile) : imageFile; @@ -74,7 +74,7 @@ const markedImageDisplay = ({ imageFiles, shouldBuildImageObjectURL }) => { alt, display, imageId, - src, + source, }, }; } catch (error) { @@ -90,7 +90,7 @@ const markedImageDisplay = ({ imageFiles, shouldBuildImageObjectURL }) => { alt, display, imageId, - src: imageId, + source: imageId, }, }; } diff --git a/src/markdown-processor/marked-extentions/image-link.js b/src/markdown-processor/marked-extentions/image-link.js index b50a84b..37efd22 100644 --- a/src/markdown-processor/marked-extentions/image-link.js +++ b/src/markdown-processor/marked-extentions/image-link.js @@ -60,7 +60,7 @@ const markedImageLink = ({ imageFiles, shouldBuildImageObjectURL }) => { try { const imageFile = imageFiles[imageId]; - const src = shouldBuildImageObjectURL + const source = shouldBuildImageObjectURL ? blobUrlManager(imageId, imageFile) : imageFile; @@ -73,7 +73,7 @@ const markedImageLink = ({ imageFiles, shouldBuildImageObjectURL }) => { meta: { alt, imageId, - src, + source, target, }, }; @@ -89,7 +89,7 @@ const markedImageLink = ({ imageFiles, shouldBuildImageObjectURL }) => { meta: { alt, imageId, - src: imageId, + source: imageId, target, }, }; diff --git a/src/markdown-processor/marked-extentions/image.js b/src/markdown-processor/marked-extentions/image.js index eca2218..01541fb 100644 --- a/src/markdown-processor/marked-extentions/image.js +++ b/src/markdown-processor/marked-extentions/image.js @@ -24,11 +24,11 @@ const markedImage = ({ imageFiles, shouldBuildImageObjectURL }) => { const imageId = token.href; const imageFile = imageFiles[imageId]; - const src = shouldBuildImageObjectURL + const source = shouldBuildImageObjectURL ? blobUrlManager(imageId, imageFile) : imageFile; - return { alt, imageId, src }; + return { alt, imageId, source }; }, parseChildren: false, onError(error, token) { @@ -36,7 +36,7 @@ const markedImage = ({ imageFiles, shouldBuildImageObjectURL }) => { return { alt: token.text, imageId: token.href, - src: token.href, + source: token.href, }; }, }), diff --git a/src/markup-converters/react/default-components/image-display-link/ImageDisplayLink.jsx b/src/markup-converters/react/default-components/image-display-link/ImageDisplayLink.jsx index 4e107c2..7bb9242 100644 --- a/src/markup-converters/react/default-components/image-display-link/ImageDisplayLink.jsx +++ b/src/markup-converters/react/default-components/image-display-link/ImageDisplayLink.jsx @@ -5,13 +5,13 @@ const ImageDisplayLink = ({ alt = '', display = '', imageId = '', - src = '', + source = '', target = '', }) => { return (
- {alt} + {alt}
{display}
@@ -22,7 +22,7 @@ ImageDisplayLink.propTypes = { alt: PropTypes.string, display: PropTypes.string, imageId: PropTypes.string, - src: PropTypes.string, + source: PropTypes.string, target: PropTypes.string.isRequired, position: PropTypes.shape({ start: PropTypes.number, end: PropTypes.number }), }; diff --git a/src/markup-converters/react/default-components/image-display/ImageDisplay.jsx b/src/markup-converters/react/default-components/image-display/ImageDisplay.jsx index c676cbd..27f3695 100644 --- a/src/markup-converters/react/default-components/image-display/ImageDisplay.jsx +++ b/src/markup-converters/react/default-components/image-display/ImageDisplay.jsx @@ -1,10 +1,15 @@ import React from 'react'; import PropTypes from 'prop-types'; -const ImageDisplay = ({ alt = '', display = '', imageId = '', src = '' }) => { +const ImageDisplay = ({ + alt = '', + display = '', + imageId = '', + source = '', +}) => { return (
- {alt} + {alt}
{display}
); @@ -14,7 +19,7 @@ ImageDisplay.propTypes = { alt: PropTypes.string, display: PropTypes.string, imageId: PropTypes.string, - src: PropTypes.string, + source: PropTypes.string, position: PropTypes.shape({ start: PropTypes.number, end: PropTypes.number }), }; diff --git a/src/markup-converters/react/default-components/image-link/ImageLink.jsx b/src/markup-converters/react/default-components/image-link/ImageLink.jsx index 7227e09..1f2ee9c 100644 --- a/src/markup-converters/react/default-components/image-link/ImageLink.jsx +++ b/src/markup-converters/react/default-components/image-link/ImageLink.jsx @@ -1,10 +1,10 @@ import React from 'react'; import PropTypes from 'prop-types'; -const ImageLink = ({ alt = '', imageId = '', src = '', target = '' }) => { +const ImageLink = ({ alt = '', imageId = '', source = '', target = '' }) => { return ( - {alt} + {alt} ); }; @@ -12,7 +12,7 @@ const ImageLink = ({ alt = '', imageId = '', src = '', target = '' }) => { ImageLink.propTypes = { alt: PropTypes.string, imageId: PropTypes.string, - src: PropTypes.string, + source: PropTypes.string, target: PropTypes.string.isRequired, position: PropTypes.shape({ start: PropTypes.number, end: PropTypes.number }), }; diff --git a/src/markup-converters/react/default-components/image/Image.jsx b/src/markup-converters/react/default-components/image/Image.jsx index b31946c..549896a 100644 --- a/src/markup-converters/react/default-components/image/Image.jsx +++ b/src/markup-converters/react/default-components/image/Image.jsx @@ -1,14 +1,14 @@ import React from 'react'; import PropTypes from 'prop-types'; -const Image = ({ alt = '', imageId = '', src = '' }) => { - return {alt}; +const Image = ({ alt = '', imageId = '', source = '' }) => { + return {alt}; }; Image.propTypes = { alt: PropTypes.string, imageId: PropTypes.string, - src: PropTypes.string, + source: PropTypes.string, position: PropTypes.shape({ start: PropTypes.number, end: PropTypes.number }), }; From 06192b110f2cf42e063999a536a6188915462198 Mon Sep 17 00:00:00 2001 From: Wendy Sun Date: Wed, 25 Feb 2026 22:09:30 +0800 Subject: [PATCH 2/2] chore: bump package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 68034ff..0de84fe 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@coseeing/see-mark", - "version": "1.4.1", + "version": "1.4.2", "description": "A markdown parser for a11y", "main": "./lib/see-mark.cjs", "files": [