feat(backend): fix ut

Author: kidkidkid

backend/modules/observability/domain/metric/service/metric/metric_definitions_test.go

@@ -15,6 +15,7 @@ import (
 	"go.uber.org/mock/gomock"
 
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/entity"
+	consts "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/service/metric/const"
 	generalmetrics "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/service/metric/general"
 	modelmetrics "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/service/metric/model"
 	servicemetrics "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/service/metric/service"
@@ -204,6 +205,7 @@ func renderExpressions(t *testing.T, defs []entity.IMetricDefinition, gran entit
 		_ = def.Type()
 		_ = def.GroupBy()
 		_ = def.Source()
+		_ = def.OExpression()
 		_, _ = def.Where(context.Background(), f, nil)
 		res[def.Name()] = renderExpression(t, def, gran)
 	}
@@ -239,6 +241,77 @@ func expectedBaseExpression(name string, gran entity.MetricGranularity) (string,
 	return "", false
 }
 
+// 额外覆盖：校验各 Wrapper 与复合指标、常量指标的行为
+func TestWrapperProperties(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	defs := []entity.IMetricDefinition{
+		modelmetrics.NewModelDurationMetric(),
+		servicemetrics.NewServiceDurationMetric(),
+	}
+	granularities := []entity.MetricGranularity{entity.MetricGranularity1Min, entity.MetricGranularity1Hour}
+
+	for _, def := range defs {
+		adapter, ok := def.(entity.IMetricAdapter)
+		require.True(t, ok)
+		wrappers := adapter.Wrappers()
+		require.NotEmpty(t, wrappers)
+		for _, w := range wrappers {
+			wrapped := w.Wrap(def)
+			// 名称后缀断言
+			name := wrapped.Name()
+			require.True(t, strings.HasPrefix(name, def.Name()))
+			require.True(t, strings.HasSuffix(name, "_avg") || strings.HasSuffix(name, "_min") || strings.HasSuffix(name, "_max") || strings.HasSuffix(name, "_pct50") || strings.HasSuffix(name, "_pct90") || strings.HasSuffix(name, "_pct99") || strings.HasSuffix(name, "_sum") || strings.HasSuffix(name, "_by_time"))
+			// 类型与表达式不为空
+			require.NotEmpty(t, wrapped.Type())
+			for _, gran := range granularities {
+				expr := wrapped.Expression(gran)
+				require.NotNil(t, expr)
+				require.NotEmpty(t, expr.Expression)
+			}
+			// OExpression 非空（用于离线计算）
+			require.NotNil(t, wrapped.OExpression())
+			// Where/GroupBy 可调用
+			f := spanfiltermocks.NewMockFilter(ctrl)
+			f.EXPECT().BuildLLMSpanFilter(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
+			f.EXPECT().BuildRootSpanFilter(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
+			_, _ = wrapped.Where(context.Background(), f, nil)
+			_ = wrapped.GroupBy()
+		}
+	}
+}
+
+func TestCompoundMetricsDefinition(t *testing.T) {
+	compoundDefs := []entity.IMetricDefinition{
+		generalmetrics.NewGeneralModelLatencyMetric(),
+		generalmetrics.NewGeneralToolLatencyMetric(),
+	}
+	for _, def := range compoundDefs {
+		compound, ok := def.(entity.IMetricCompound)
+		require.True(t, ok)
+		// 复合指标的运算符与子指标集合
+		require.Equal(t, entity.MetricOperatorDivide, compound.Operator())
+		subs := compound.GetMetrics()
+		require.Len(t, subs, 2)
+		// 子指标的表达式可渲染
+		for _, sub := range subs {
+			expr := sub.Expression(entity.MetricGranularity1Min)
+			require.NotNil(t, expr)
+		}
+	}
+}
+
+func TestConstMinuteMetric(t *testing.T) {
+	def := consts.NewConstMinuteMetric()
+	// 常量指标基本属性
+	require.Equal(t, entity.MetricTypeSummary, def.Type())
+	// 1min 粒度下表达式应为 "1"
+	expr := def.Expression(entity.MetricGranularity1Min)
+	require.NotNil(t, expr)
+	require.Equal(t, "1", expr.Expression)
+}
+
 var baseExpressionGenerators = map[string]func(entity.MetricGranularity) string{
 	entity.MetricNameGeneralTotalCount:         countExpr,
 	entity.MetricNameGeneralToolTotalCount:     countExpr,

backend/modules/observability/domain/metric/service/offline_metric_test.go

@@ -12,6 +12,7 @@ import (
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/entity"
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/repo"
 	repomocks "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/repo/mocks"
+	consts "github.com/coze-dev/coze-loop/backend/modules/observability/domain/metric/service/metric/const"
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/trace/entity/loop_span"
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/trace/service/trace/span_filter"
 	"github.com/stretchr/testify/assert"
@@ -93,7 +94,7 @@ func TestMetricsService_buildDrillDownFields(t *testing.T) {
 						FieldType: loop_span.FieldTypeString,
 					},
 					"group_obj": {
-						FieldName: "group_field", 
+						FieldName: "group_field",
 						FieldType: loop_span.FieldTypeString,
 					},
 					"metric_obj": {
@@ -128,12 +129,12 @@ func TestMetricsService_buildDrillDownFields(t *testing.T) {
 		result := svc.buildDrillDownFields(platformCfg, groupCfg, definition)
 
 		assert.Len(t, result, 4) // platform + group + metric + space_id
-		
+
 		fieldNames := make([]string, len(result))
 		for i, field := range result {
 			fieldNames[i] = field.FieldName
 		}
-		
+
 		assert.Contains(t, fieldNames, "platform_field")
 		assert.Contains(t, fieldNames, "group_field")
 		assert.Contains(t, fieldNames, "metric_field")
@@ -183,7 +184,7 @@ func TestMetricsService_buildDrillDownFields(t *testing.T) {
 				fieldCount++
 			}
 		}
-		
+
 		assert.Equal(t, 1, fieldCount) // 同一个字段只应该出现一次
 		assert.Len(t, result, 2)       // common_field + space_id
 	})
@@ -230,11 +231,11 @@ func TestMetricsService_extractMetrics(t *testing.T) {
 		events := svc.extractMetrics("test_metric", metric)
 
 		assert.Len(t, events, 2)
-		
+
 		// 验证第一个事件（有分组）
 		assert.Equal(t, "100", events[0].MetricValue)
 		assert.Equal(t, "group1", events[0].ObjectKeys["group_field"])
-		
+
 		// 验证第二个事件（默认分组）
 		assert.Equal(t, "200", events[1].MetricValue)
 		assert.Empty(t, events[1].ObjectKeys)
@@ -291,14 +292,14 @@ func TestMetricsService_extractMetrics(t *testing.T) {
 			Pie: map[string]string{
 				`{"category_alias":"A"}`: "100",
 				`{"category_alias":"B"}`: "200",
-				"all":                     "300",
+				"all":                    "300",
 			},
 		}
 
 		events := svc.extractMetrics("test_metric", metric)
 
 		assert.Len(t, events, 3)
-		
+
 		// 验证事件值
 		values := make([]string, len(events))
 		for i, event := range events {
@@ -335,7 +336,7 @@ func TestMetricsService_queryOfflineMetrics(t *testing.T) {
 		defer ctrl.Finish()
 
 		repoMock := repomocks.NewMockIOfflineMetricRepo(ctrl)
-		
+
 		// 模拟多次查询调用
 		repoMock.EXPECT().
 			GetMetrics(gomock.Any(), gomock.Any()).
@@ -353,7 +354,7 @@ func TestMetricsService_queryOfflineMetrics(t *testing.T) {
 		}
 
 		metricDefB := &testMetricDefinition{
-			name:       "metric_b", 
+			name:       "metric_b",
 			metricType: entity.MetricTypeSummary,
 		}
 
@@ -411,7 +412,7 @@ func TestMetricsService_queryOfflineMetrics(t *testing.T) {
 		defer ctrl.Finish()
 
 		repoMock := repomocks.NewMockIOfflineMetricRepo(ctrl)
-		
+
 		repoMock.EXPECT().
 			GetMetrics(gomock.Any(), gomock.Any()).
 			Return(nil, errors.New("database error")).
@@ -523,7 +524,7 @@ func TestMetricsService_buildOfflineMetricQuery(t *testing.T) {
 
 		assert.NoError(t, err)
 		assert.NotNil(t, builder)
-		
+
 		// 验证过滤条件中使用了自定义的metric name
 		filters := builder.mRepoReq.Filters
 		assert.NotNil(t, filters)
@@ -603,12 +604,7 @@ func TestMetricsService_buildTraverseMetrics(t *testing.T) {
 		ctrl := gomock.NewController(t)
 		defer ctrl.Finish()
 
-		constDef := &testConstMetricDefinition{
-			testMetricDefinition: &testMetricDefinition{
-				name:       "const_metric",
-				metricType: entity.MetricTypeSummary,
-			},
-		}
+		constDef := consts.NewConstMinuteMetric()
 
 		pMetrics := &entity.PlatformMetrics{
 			MetricGroups: map[string]*entity.MetricGroup{
@@ -626,19 +622,18 @@ func TestMetricsService_buildTraverseMetrics(t *testing.T) {
 
 		svc := &MetricsService{
 			metricDefMap: map[string]entity.IMetricDefinition{
-				"const_metric": constDef,
+				constDef.Name(): constDef,
 			},
 			pMetrics: pMetrics,
 		}
 
 		metrics, err := svc.buildTraverseMetrics(context.Background(), &TraverseMetricsReq{
 			PlatformTypes: []loop_span.PlatformType{"test_platform"},
-			MetricsNames:  []string{"const_metric"},
+			MetricsNames:  []string{},
 		})
 
 		assert.NoError(t, err)
-		assert.Len(t, metrics, 1) // 常量指标在buildTraverseMetrics中不会被跳过，只有在traverseMetric中才会被跳过
-		// 注意：常量指标是在traverseMetric阶段被跳过的，不是在buildTraverseMetrics阶段
+		assert.Len(t, metrics, 0)
 	})
 
 	t.Run("metric not found in metricDefMap", func(t *testing.T) {
@@ -704,7 +699,7 @@ func TestMetricsService_buildTraverseMetrics(t *testing.T) {
 		defer ctrl.Finish()
 
 		pMetrics := &entity.PlatformMetrics{
-			MetricGroups: map[string]*entity.MetricGroup{},
+			MetricGroups:     map[string]*entity.MetricGroup{},
 			DrillDownObjects: map[string]*loop_span.FilterField{},
 			PlatformMetricDefs: map[loop_span.PlatformType]*entity.PlatformMetricDef{
 				loop_span.PlatformType("test_platform"): {
@@ -768,26 +763,19 @@ func TestMetricsService_buildTraverseMetrics(t *testing.T) {
 			WorkspaceID:   1,
 			StartDate:     "2025-11-17",
 		}
-		
+
 		// 模拟TraverseMetrics方法中的处理逻辑
 		if len(req.PlatformTypes) == 0 {
 			req.PlatformTypes = []loop_span.PlatformType{"platform1", "platform2"}
 		}
-		
+
 		metrics, err := svc.buildTraverseMetrics(context.Background(), req)
 
 		assert.NoError(t, err)
 		assert.Len(t, metrics, 2) // 两个平台类型
 	})
 }
 
-// 辅助测试结构体
-type testConstMetricDefinition struct {
-	*testMetricDefinition
-}
-
-func (d *testConstMetricDefinition) constFunc() {}
-
 // 自定义测试指标定义，支持自定义OExpression
 type customTestMetricDefinition struct {
 	name              string
@@ -829,4 +817,4 @@ func (d *customTestMetricDefinition) OExpression() *entity.OExpression {
 		AggrType:   entity.MetricOfflineAggrTypeSum,
 		MetricName: d.name,
 	}
-}
+}